Unverified Commit e93fd333 authored by James Lamb's avatar James Lamb Committed by GitHub
Browse files

[ci] simplify R CI scripts (#3535)

* [ci] simplify R CI scripts

* update GitHub Actions workflow
parent a5448233
...@@ -108,7 +108,7 @@ if [[ $TASK == "r-package-check-docs" ]]; then ...@@ -108,7 +108,7 @@ if [[ $TASK == "r-package-check-docs" ]]; then
Rscript --vanilla -e "install.packages('roxygen2', repos = '${CRAN_MIRROR}', lib = '${R_LIB_PATH}', dependencies = c('Depends', 'Imports', 'LinkingTo'))" || exit -1 Rscript --vanilla -e "install.packages('roxygen2', repos = '${CRAN_MIRROR}', lib = '${R_LIB_PATH}', dependencies = c('Depends', 'Imports', 'LinkingTo'))" || exit -1
Rscript --vanilla -e "roxygen2::roxygenize('R-package/', load = 'installed')" || exit -1 Rscript --vanilla -e "roxygen2::roxygenize('R-package/', load = 'installed')" || exit -1
num_doc_files_changed=$( num_doc_files_changed=$(
git diff --name-only | grep -E "\.Rd|NAMESPACE" | wc -l git diff --name-only | grep --count -E "\.Rd|NAMESPACE"
) )
if [[ ${num_doc_files_changed} -gt 0 ]]; then if [[ ${num_doc_files_changed} -gt 0 ]]; then
echo "Some R documentation files have changed. Please re-generate them and commit those changes." echo "Some R documentation files have changed. Please re-generate them and commit those changes."
...@@ -208,8 +208,7 @@ fi ...@@ -208,8 +208,7 @@ fi
if [[ $OS_NAME == "macos" ]] && [[ $R_BUILD_TYPE == "cran" ]]; then if [[ $OS_NAME == "macos" ]] && [[ $R_BUILD_TYPE == "cran" ]]; then
omp_working=$( omp_working=$(
cat $BUILD_LOG_FILE \ cat $BUILD_LOG_FILE \
| grep -E "checking whether OpenMP will work .*yes" \ | grep --count -E "checking whether OpenMP will work .*yes"
| wc -l
) )
if [[ $omp_working -ne 1 ]]; then if [[ $omp_working -ne 1 ]]; then
echo "OpenMP was not found, and should be when testing the CRAN package on macOS" echo "OpenMP was not found, and should be when testing the CRAN package on macOS"
...@@ -222,8 +221,7 @@ fi ...@@ -222,8 +221,7 @@ fi
if [[ $R_BUILD_TYPE == "cran" ]]; then if [[ $R_BUILD_TYPE == "cran" ]]; then
pragma_warning_present=$( pragma_warning_present=$(
cat $BUILD_LOG_FILE \ cat $BUILD_LOG_FILE \
| grep -E "warning: unknown pragma ignored" \ | grep --count -E "warning: unknown pragma ignored"
| wc -l
) )
if [[ $pragma_warning_present -ne 0 ]]; then if [[ $pragma_warning_present -ne 0 ]]; then
echo "Unknown pragma warning is present, pragmas should have been removed before build" echo "Unknown pragma warning is present, pragmas should have been removed before build"
......
...@@ -70,13 +70,12 @@ tzutil /s "GMT Standard Time" ...@@ -70,13 +70,12 @@ tzutil /s "GMT Standard Time"
[Void][System.IO.Directory]::CreateDirectory($env:R_LIB_PATH) [Void][System.IO.Directory]::CreateDirectory($env:R_LIB_PATH)
if ($env:R_BUILD_TYPE -eq "cmake") { if ($env:R_BUILD_TYPE -eq "cmake") {
$install_libs = "$env:BUILD_SOURCESDIRECTORY/R-package/src/install.libs.R"
if ($env:TOOLCHAIN -eq "MINGW") { if ($env:TOOLCHAIN -eq "MINGW") {
Write-Output "Telling R to use MinGW" Write-Output "Telling R to use MinGW"
$install_libs = "$env:BUILD_SOURCESDIRECTORY/R-package/src/install.libs.R"
((Get-Content -Path $install_libs -Raw) -Replace 'use_mingw <- FALSE','use_mingw <- TRUE') | Set-Content -Path $install_libs ((Get-Content -Path $install_libs -Raw) -Replace 'use_mingw <- FALSE','use_mingw <- TRUE') | Set-Content -Path $install_libs
} elseif ($env:TOOLCHAIN -eq "MSYS") { } elseif ($env:TOOLCHAIN -eq "MSYS") {
Write-Output "Telling R to use MSYS" Write-Output "Telling R to use MSYS"
$install_libs = "$env:BUILD_SOURCESDIRECTORY/R-package/src/install.libs.R"
((Get-Content -Path $install_libs -Raw) -Replace 'use_msys2 <- FALSE','use_msys2 <- TRUE') | Set-Content -Path $install_libs ((Get-Content -Path $install_libs -Raw) -Replace 'use_msys2 <- FALSE','use_msys2 <- TRUE') | Set-Content -Path $install_libs
} elseif ($env:TOOLCHAIN -eq "MSVC") { } elseif ($env:TOOLCHAIN -eq "MSVC") {
# no customization for MSVC # no customization for MSVC
......
...@@ -187,7 +187,7 @@ jobs: ...@@ -187,7 +187,7 @@ jobs:
cd R-package/tests cd R-package/tests
Rscriptdevel testthat.R 2>&1 > ubsan-tests.log Rscriptdevel testthat.R 2>&1 > ubsan-tests.log
cat ubsan-tests.log cat ubsan-tests.log
exit $(cat ubsan-tests.log | grep "runtime error" | wc -l) exit $(cat ubsan-tests.log | grep --count "runtime error")
all-successful: all-successful:
# https://github.community/t/is-it-possible-to-require-all-github-actions-tasks-to-pass-without-enumerating-them/117957/4?u=graingert # https://github.community/t/is-it-possible-to-require-all-github-actions-tasks-to-pass-without-enumerating-them/117957/4?u=graingert
runs-on: ubuntu-latest runs-on: ubuntu-latest
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment