Skip to content

GitLab

Commit cba87c37 authored by cbecker's avatar cbecker Committed by Guolin Ke
Browse files

Fixed gcc non virtual destructor warning (bin.h) and ignored const specifier (dataset.h) (#273)

parent 4f3e9d89
Show whitespace changes
Inline Side-by-side
Showing with 2 additions and 1 deletion
include/LightGBM/bin.h
View file @ cba87c37
...@@ -242,6 +242,7 @@ public: ...@@ -242,6 +242,7 @@ public:
* \return Bin data * \return Bin data
*/ */
virtual uint32_t Get(data_size_t idx) = 0; virtual uint32_t Get(data_size_t idx) = 0;
virtual ~BinIterator() = default;
}; };
/*! /*!
......
include/LightGBM/dataset.h
View file @ cba87c37
...@@ -173,7 +173,7 @@ public: ...@@ -173,7 +173,7 @@ public:
* \brief Get Number of queries * \brief Get Number of queries
* \return Number of queries * \return Number of queries
*/ */
inline const data_size_t num_queries() const { return num_queries_; } inline data_size_t num_queries() const { return num_queries_; }
/*! /*!
* \brief Get weights for queries, if not exists, will return nullptr * \brief Get weights for queries, if not exists, will return nullptr
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment