[cmake] [c++] use .dylib extension unconditionally on macOS (#6418)

.ci/test.sh

@@ -59,11 +59,7 @@ if [[ $TASK == "if-else" ]]; then
 fi
 
 if [[ $TASK == "swig" ]]; then
-    if [[ $OS_NAME == "macos" ]]; then
-        cmake -B build -S . -DUSE_SWIG=ON -DAPPLE_OUTPUT_DYLIB=ON
-    else
     cmake -B build -S . -DUSE_SWIG=ON
-    fi
     cmake --build build -j4 || exit 1
     if [[ $OS_NAME == "linux" ]] && [[ $COMPILER == "gcc" ]]; then
         objdump -T $BUILD_DIRECTORY/lib_lightgbm.so > $BUILD_DIRECTORY/objdump.log || exit 1
@@ -298,7 +294,7 @@ pytest $BUILD_DIRECTORY/tests || exit 1
 if [[ $TASK == "regular" ]]; then
     if [[ $PRODUCES_ARTIFACTS == "true" ]]; then
         if [[ $OS_NAME == "macos" ]]; then
-            cp $BUILD_DIRECTORY/lib_lightgbm.so $BUILD_ARTIFACTSTAGINGDIRECTORY/lib_lightgbm.dylib
+            cp $BUILD_DIRECTORY/lib_lightgbm.dylib $BUILD_ARTIFACTSTAGINGDIRECTORY/lib_lightgbm.dylib
         else
             if [[ $COMPILER == "gcc" ]]; then
                 objdump -T $BUILD_DIRECTORY/lib_lightgbm.so > $BUILD_DIRECTORY/objdump.log || exit 1

CMakeLists.txt

@@ -23,10 +23,6 @@ option(__BUILD_FOR_PYTHON "Set to ON if building lib_lightgbm for use with the P
 option(__BUILD_FOR_R "Set to ON if building lib_lightgbm for use with the R package" OFF)
 option(__INTEGRATE_OPENCL "Set to ON if building LightGBM with the OpenCL ICD Loader and its dependencies included" OFF)
 
-if(APPLE)
-  option(APPLE_OUTPUT_DYLIB "Output dylib shared library" OFF)
-endif()
-
 cmake_minimum_required(VERSION 3.18)
 
 project(lightgbm LANGUAGES C CXX)
@@ -407,14 +403,6 @@ set(LIBRARY_OUTPUT_PATH ${PROJECT_SOURCE_DIR})
 
 include_directories(${LightGBM_HEADER_DIR})
 
-if(APPLE)
-  if(APPLE_OUTPUT_DYLIB)
-    set(CMAKE_SHARED_LIBRARY_SUFFIX ".dylib")
-  else()
-    set(CMAKE_SHARED_LIBRARY_SUFFIX ".so")
-  endif()
-endif()
-
 if(USE_MPI)
   include_directories(${MPI_CXX_INCLUDE_PATH})
 endif()

R-package/.Rbuildignore

@@ -8,6 +8,7 @@ AUTOCONF_UBUNTU_VERSION
 ^docs$
 ^.*\.dll
 \.drone\.yml
+^.*\.dylib
 \.git
 \.gitkeep$
 ^.*\.history

R-package/README.md

@@ -221,7 +221,7 @@ CRAN does not prepare precompiled binaries for Linux, and as of this writing nei
 
 ### Installing from a Pre-compiled lib_lightgbm <a name="lib_lightgbm"></a>
 
-Previous versions of LightGBM offered the ability to first compile the C++ library (`lib_lightgbm.so` or `lib_lightgbm.dll`) and then build an R package that wraps it.
+Previous versions of LightGBM offered the ability to first compile the C++ library (`lib_lightgbm.{dll,dylib,so}`) and then build an R package that wraps it.
 
 As of version 3.0.0, this is no longer supported. If building from source is difficult for you, please [open an issue](https://github.com/microsoft/LightGBM/issues).
 

R-package/src/install.libs.R

@@ -183,7 +183,9 @@ R_version_string <- paste(
   , sep = "."
 )
 r_version_arg <- sprintf("-DCMAKE_R_VERSION='%s'", R_version_string)
-cmake_args <- c(cmake_args, r_version_arg)
+# ensure CMake build respects how R is configured (`R CMD config SHLIB_EXT`)
+shlib_ext_arg <- sprintf("-DCMAKE_SHARED_LIBRARY_SUFFIX_CXX='%s'", SHLIB_EXT)
+cmake_args <- c(cmake_args, r_version_arg, shlib_ext_arg)
 
 # the checks below might already run `cmake -G`. If they do, set this flag
 # to TRUE to avoid re-running it later

build-cran-package.sh

@@ -167,7 +167,7 @@ cd "${TEMP_R_DIR}"
 
     # When building an R package with 'configure', it seems
     # you're guaranteed to get a shared library called
-    #  <packagename>.so/dll. The package source code expects
+    #  <packagename>.so/dll/dylib. The package source code expects
     # 'lib_lightgbm.so', not 'lightgbm.so', to comply with the way
     # this project has historically handled installation
     echo "Changing lib_lightgbm to lightgbm"

build-python.sh

@@ -317,12 +317,15 @@ if test "${INSTALL}" = true; then
         echo 'requires = ["setuptools"]' >> ./pyproject.toml
         echo 'build-backend = "setuptools.build_meta"' >> ./pyproject.toml
         echo "" >> ./pyproject.toml
-        echo "recursive-include lightgbm *.dll *.so" > ./MANIFEST.in
+        echo "recursive-include lightgbm *.dll *.dylib *.so" > ./MANIFEST.in
         echo "" >> ./MANIFEST.in
         mkdir -p ./lightgbm/lib
         if test -f ../lib_lightgbm.so; then
             echo "found pre-compiled lib_lightgbm.so"
             cp ../lib_lightgbm.so ./lightgbm/lib/lib_lightgbm.so
+        elif test -f ../lib_lightgbm.dylib; then
+            echo "found pre-compiled lib_lightgbm.dylib"
+            cp ../lib_lightgbm.dylib ./lightgbm/lib/lib_lightgbm.dylib
         elif test -f ../Release/lib_lightgbm.dll; then
             echo "found pre-compiled Release/lib_lightgbm.dll"
             cp ../Release/lib_lightgbm.dll ./lightgbm/lib/lib_lightgbm.dll

docs/Installation-Guide.rst

@@ -763,7 +763,7 @@ Only **Apple Clang** version 8.1 or higher is supported.
 
      git clone --recursive https://github.com/microsoft/LightGBM
      cd LightGBM
-     cmake -B build -S . -DUSE_SWIG=ON -DAPPLE_OUTPUT_DYLIB=ON
+     cmake -B build -S . -DUSE_SWIG=ON
      cmake --build build -j4
 
 gcc
@@ -788,7 +788,7 @@ gcc
      git clone --recursive https://github.com/microsoft/LightGBM
      cd LightGBM
      export CXX=g++-7 CC=gcc-7  # replace "7" with version of gcc installed on your machine
-     cmake -B build -S . -DUSE_SWIG=ON -DAPPLE_OUTPUT_DYLIB=ON
+     cmake -B build -S . -DUSE_SWIG=ON
      cmake --build build -j4
 
 Also, you may want to read `gcc Tips <./gcc-Tips.rst>`__.

python-package/lightgbm/libpath.py

@@ -25,6 +25,8 @@ def find_lib_path() -> List[str]:
         dll_path.append(curr_path.parents[1] / "Release")
         dll_path.append(curr_path.parents[1] / "windows" / "x64" / "DLL")
         dll_path = [p / "lib_lightgbm.dll" for p in dll_path]
+    elif system() == "Darwin":
+        dll_path = [p / "lib_lightgbm.dylib" for p in dll_path]
     else:
         dll_path = [p / "lib_lightgbm.so" for p in dll_path]
     lib_path = [str(p) for p in dll_path if p.is_file()]