fix overflow in WeightedPercentile

8ffd8d80 · Guolin Ke · 5b5b9823 · 8ffd8d80
Commit 8ffd8d80 authored Apr 16, 2019 by Guolin Ke
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

src/objective/regression_objective.hpp src/objective/regression_objective.hpp +1 -1

No files found.
--- a/src/objective/regression_objective.hpp
+++ b/src/objective/regression_objective.hpp
@@ -65,7 +65,7 @@ namespace LightGBM {
  CHECK(threshold < weighted_cdf[pos]);\
  T v1 = data_reader(sorted_idx[pos - 1]);\
  T v2 = data_reader(sorted_idx[pos]);\
-  if (weighted_cdf[pos + 1] - weighted_cdf[pos] > kEpsilon) {\
+  if (weighted_cdf[pos + 1] - weighted_cdf[pos] >= 1.0f) {\
    return static_cast<T>((threshold - weighted_cdf[pos]) / (weighted_cdf[pos + 1] - weighted_cdf[pos]) * (v2 - v1) + v1); \
  } else {\
    return static_cast<T>(v2);\