Fix SingleRowPredictor::IsPredictorEqual comparison (invert) (#2799)

60710c70 · Alberto Ferreira · GitHub · 060c681d · 60710c70
Unverified Commit 60710c70 authored Feb 24, 2020 by Alberto Ferreira Committed by GitHub Feb 24, 2020
Show whitespace changes
Inline Side-by-side

Showing with 7 additions and 5 deletions

src/c_api.cpp src/c_api.cpp +7 -5

No files found.
--- a/src/c_api.cpp
+++ b/src/c_api.cpp
@@ -77,13 +77,15 @@ class SingleRowPredictor {
    predict_function = predictor_->GetPredictFunction();
    num_total_model_ = boosting->NumberOfTotalModel();
  }
+
  ~SingleRowPredictor() {}
+
  bool IsPredictorEqual(const Config& config, int iter, Boosting* boosting) {
-    return early_stop_ != config.pred_early_stop ||
-      early_stop_freq_ != config.pred_early_stop_freq ||
-      early_stop_margin_ != config.pred_early_stop_margin ||
-      iter_ != iter ||
-      num_total_model_ != boosting->NumberOfTotalModel();
+    return early_stop_ == config.pred_early_stop &&
+      early_stop_freq_ == config.pred_early_stop_freq &&
+      early_stop_margin_ == config.pred_early_stop_margin &&
+      iter_ == iter &&
+      num_total_model_ == boosting->NumberOfTotalModel();
  }

 private: