"vscode:/vscode.git/clone" did not exist on "f74875ed60e696ee7d223ddb409e66f51bddbb47"
Unverified Commit 5df7d516 authored by IdoKendo's avatar IdoKendo Committed by GitHub
Browse files

[python-package] fix mypy errors for eval_at and basic (#5674)

parent 02d212b4
......@@ -2186,7 +2186,7 @@ class Dataset:
def set_categorical_feature(
self,
categorical_feature: Union[List[int], List[str]]
categorical_feature: Union[List[int], List[str], str]
) -> "Dataset":
"""Set categorical features.
......@@ -2268,7 +2268,7 @@ class Dataset:
raise LightGBMError("Cannot set reference after freed raw data, "
"set free_raw_data=False when construct Dataset to avoid this.")
def set_feature_name(self, feature_name: List[str]) -> "Dataset":
def set_feature_name(self, feature_name: Union[List[str], str]) -> "Dataset":
"""Set feature name.
Parameters
......
......@@ -413,7 +413,7 @@ def _train(
eval_init_score: Optional[List[_DaskCollection]] = None,
eval_group: Optional[List[_DaskVectorLike]] = None,
eval_metric: Optional[_LGBM_ScikitEvalMetricType] = None,
eval_at: Optional[Union[List[int], Tuple[int]]] = None,
eval_at: Optional[Union[List[int], Tuple[int, ...]]] = None,
**kwargs: Any
) -> LGBMModel:
"""Inner train routine.
......@@ -1045,7 +1045,7 @@ class _DaskLGBMModel:
eval_init_score: Optional[List[_DaskCollection]] = None,
eval_group: Optional[List[_DaskVectorLike]] = None,
eval_metric: Optional[_LGBM_ScikitEvalMetricType] = None,
eval_at: Optional[Iterable[int]] = None,
eval_at: Optional[Union[List[int], Tuple[int, ...]]] = None,
**kwargs: Any
) -> "_DaskLGBMModel":
if not DASK_INSTALLED:
......@@ -1499,7 +1499,7 @@ class DaskLGBMRanker(LGBMRanker, _DaskLGBMModel):
eval_init_score: Optional[List[_DaskVectorLike]] = None,
eval_group: Optional[List[_DaskVectorLike]] = None,
eval_metric: Optional[_LGBM_ScikitEvalMetricType] = None,
eval_at: Union[List[int], Tuple[int]] = (1, 2, 3, 4, 5),
eval_at: Union[List[int], Tuple[int, ...]] = (1, 2, 3, 4, 5),
**kwargs: Any
) -> "DaskLGBMRanker":
"""Docstring is inherited from the lightgbm.LGBMRanker.fit."""
......
......@@ -1204,7 +1204,7 @@ class LGBMRanker(LGBMModel):
eval_init_score=None,
eval_group=None,
eval_metric: Optional[_LGBM_ScikitEvalMetricType] = None,
eval_at: Union[List[int], Tuple[int]] = (1, 2, 3, 4, 5),
eval_at: Union[List[int], Tuple[int, ...]] = (1, 2, 3, 4, 5),
feature_name='auto',
categorical_feature='auto',
callbacks=None,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment