Unverified Commit 5aaaec8e authored by James Lamb's avatar James Lamb Committed by GitHub
Browse files

[ci] [python-package] re-enable scikit-build-core binary stripping (#6872)

parent 82c85e40
...@@ -26,7 +26,7 @@ fi ...@@ -26,7 +26,7 @@ fi
PY_MINOR_VER=$(python -c "import sys; print(sys.version_info.minor)") PY_MINOR_VER=$(python -c "import sys; print(sys.version_info.minor)")
if [ "$PY_MINOR_VER" -gt 7 ]; then if [ "$PY_MINOR_VER" -gt 7 ]; then
echo "pydistcheck..." echo "pydistcheck..."
pip install 'pydistcheck>=0.7.0' pip install 'pydistcheck>=0.9.1'
if { test "${TASK}" = "cuda" || test "${METHOD}" = "wheel"; }; then if { test "${TASK}" = "cuda" || test "${METHOD}" = "wheel"; }; then
pydistcheck \ pydistcheck \
--inspect \ --inspect \
......
...@@ -22,7 +22,7 @@ if [[ $OS_NAME == "macos" ]]; then ...@@ -22,7 +22,7 @@ if [[ $OS_NAME == "macos" ]]; then
if [[ $COMPILER == "clang" ]]; then if [[ $COMPILER == "clang" ]]; then
brew install libomp brew install libomp
else # gcc else # gcc
brew install 'gcc@12' brew install 'gcc@14'
fi fi
if [[ $TASK == "mpi" ]]; then if [[ $TASK == "mpi" ]]; then
brew install open-mpi brew install open-mpi
......
...@@ -18,14 +18,14 @@ Remove-Item $env:TMPDIR -Force -Recurse -ErrorAction Ignore ...@@ -18,14 +18,14 @@ Remove-Item $env:TMPDIR -Force -Recurse -ErrorAction Ignore
if ($env:TASK -eq "r-package") { if ($env:TASK -eq "r-package") {
& .\.ci\test-r-package-windows.ps1 ; Assert-Output $? & .\.ci\test-r-package-windows.ps1 ; Assert-Output $?
Exit 0 exit 0
} }
if ($env:TASK -eq "cpp-tests") { if ($env:TASK -eq "cpp-tests") {
cmake -B build -S . -DBUILD_CPP_TEST=ON -DUSE_DEBUG=ON -A x64 cmake -B build -S . -DBUILD_CPP_TEST=ON -DUSE_DEBUG=ON -A x64
cmake --build build --target testlightgbm --config Debug ; Assert-Output $? cmake --build build --target testlightgbm --config Debug ; Assert-Output $?
.\Debug\testlightgbm.exe ; Assert-Output $? .\Debug\testlightgbm.exe ; Assert-Output $?
Exit 0 exit 0
} }
if ($env:TASK -eq "swig") { if ($env:TASK -eq "swig") {
...@@ -59,7 +59,7 @@ if ($env:TASK -eq "swig") { ...@@ -59,7 +59,7 @@ if ($env:TASK -eq "swig") {
if ($env:AZURE -eq "true") { if ($env:AZURE -eq "true") {
cp ./build/lightgbmlib.jar $env:BUILD_ARTIFACTSTAGINGDIRECTORY/lightgbmlib_win.jar ; Assert-Output $? cp ./build/lightgbmlib.jar $env:BUILD_ARTIFACTSTAGINGDIRECTORY/lightgbmlib_win.jar ; Assert-Output $?
} }
Exit 0 exit 0
} }
# setup for Python # setup for Python
......
...@@ -14,8 +14,8 @@ ARCH=$(uname -m) ...@@ -14,8 +14,8 @@ ARCH=$(uname -m)
LGB_VER=$(head -n 1 "${BUILD_DIRECTORY}/VERSION.txt") LGB_VER=$(head -n 1 "${BUILD_DIRECTORY}/VERSION.txt")
if [[ $OS_NAME == "macos" ]] && [[ $COMPILER == "gcc" ]]; then if [[ $OS_NAME == "macos" ]] && [[ $COMPILER == "gcc" ]]; then
export CXX=g++-12 export CXX=g++-14
export CC=gcc-12 export CC=gcc-14
elif [[ $OS_NAME == "linux" ]] && [[ $COMPILER == "clang" ]]; then elif [[ $OS_NAME == "linux" ]] && [[ $COMPILER == "clang" ]]; then
export CXX=clang++ export CXX=clang++
export CC=clang export CC=clang
......
...@@ -73,9 +73,7 @@ cmake.args = [ ...@@ -73,9 +73,7 @@ cmake.args = [
build.verbose = false build.verbose = false
cmake.build-type = "Release" cmake.build-type = "Release"
build.targets = ["_lightgbm"] build.targets = ["_lightgbm"]
# stripping binaries should be turned back on once this is fixed: install.strip = true
# https://github.com/jameslamb/pydistcheck/issues/235
install.strip = false
logging.level = "INFO" logging.level = "INFO"
sdist.reproducible = true sdist.reproducible = true
wheel.py-api = "py3" wheel.py-api = "py3"
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment