reworked includes in source files (#2066)

* added all necessary includes - fixed build/include_what_you_use error

* fixed the order of includes (build/include_order)

src/metric/rank_metric.hpp

@@ -2,11 +2,11 @@
 #define LIGHTGBM_METRIC_RANK_METRIC_HPP_
 
 #include <LightGBM/metric.h>
-
 #include <LightGBM/utils/common.h>
 #include <LightGBM/utils/log.h>
 #include <LightGBM/utils/openmp_wrapper.h>
 
+#include <string>
 #include <sstream>
 #include <vector>
 

src/metric/regression_metric.hpp

@@ -2,10 +2,12 @@
 #define LIGHTGBM_METRIC_REGRESSION_METRIC_HPP_
 
 #include <LightGBM/metric.h>
-
 #include <LightGBM/utils/log.h>
 
+#include <string>
+#include <algorithm>
 #include <cmath>
+#include <vector>
 
 namespace LightGBM {
 /*!

src/metric/xentropy_metric.hpp

 #ifndef LIGHTGBM_METRIC_XENTROPY_METRIC_HPP_
 #define LIGHTGBM_METRIC_XENTROPY_METRIC_HPP_
 
-#include <LightGBM/metric.h>
 #include <LightGBM/meta.h>
-
-#include <LightGBM/utils/log.h>
+#include <LightGBM/metric.h>
 #include <LightGBM/utils/common.h>
+#include <LightGBM/utils/log.h>
 
+#include <string>
 #include <algorithm>
-#include <vector>
 #include <sstream>
+#include <vector>
 
 /*
  * Implements three related metrics:

src/network/linker_topo.cpp

 #include <LightGBM/network.h>
-
 #include <LightGBM/utils/common.h>
 #include <LightGBM/utils/log.h>
 
 #include <string>
-#include <vector>
 #include <unordered_map>
+#include <vector>
 
 namespace LightGBM {
 

src/network/linkers.h

 #ifndef LIGHTGBM_NETWORK_LINKERS_H_
 #define LIGHTGBM_NETWORK_LINKERS_H_
 
-#include <LightGBM/network.h>
-#include <LightGBM/meta.h>
 #include <LightGBM/config.h>
+#include <LightGBM/meta.h>
+#include <LightGBM/network.h>
 
-
+#include <string>
 #include <algorithm>
 #include <chrono>
 #include <ctime>
+#include <memory>
 #include <thread>
 #include <vector>
-#include <string>
-#include <memory>
 
 #ifdef USE_SOCKET
 #include "socket_wrapper.hpp"

src/network/linkers_mpi.cpp

 #ifdef USE_MPI
+
 #include "linkers.h"
 
 namespace LightGBM {

src/network/linkers_socket.cpp

 #ifdef USE_SOCKET
-#include "linkers.h"
 
+#include <LightGBM/config.h>
 #include <LightGBM/utils/common.h>
 #include <LightGBM/utils/text_reader.h>
 
-#include <LightGBM/config.h>
-
+#include <string>
+#include <chrono>
 #include <cstring>
-
+#include <thread>
 #include <unordered_map>
 #include <unordered_set>
 #include <vector>
-#include <thread>
-#include <chrono>
-#include <string>
+
+#include "linkers.h"
 
 namespace LightGBM {
 

src/network/network.cpp

@@ -2,10 +2,10 @@
 
 #include <LightGBM/utils/common.h>
 
-#include "linkers.h"
-
-#include <cstring>
 #include <cstdlib>
+#include <cstring>
+
+#include "linkers.h"
 
 namespace LightGBM {
 

src/network/socket_wrapper.hpp

@@ -28,10 +28,9 @@
 
 #include <LightGBM/utils/log.h>
 
+#include <string>
 #include <cstdlib>
-
 #include <unordered_set>
-#include <string>
 
 #ifdef _MSC_VER
 #pragma comment(lib, "Ws2_32.lib")

src/objective/binary_objective.hpp

@@ -3,8 +3,11 @@
 
 #include <LightGBM/objective_function.h>
 
-#include <cstring>
+#include <string>
+#include <algorithm>
 #include <cmath>
+#include <cstring>
+#include <vector>
 
 namespace LightGBM {
 /*!

src/objective/multiclass_objective.hpp

@@ -3,8 +3,11 @@
 
 #include <LightGBM/objective_function.h>
 
-#include <cstring>
+#include <string>
+#include <algorithm>
 #include <cmath>
+#include <cstring>
+#include <memory>
 #include <vector>
 
 #include "binary_objective.hpp"

src/objective/objective_function.cpp

 #include <LightGBM/objective_function.h>
-#include "regression_objective.hpp"
+
 #include "binary_objective.hpp"
-#include "rank_objective.hpp"
 #include "multiclass_objective.hpp"
+#include "rank_objective.hpp"
+#include "regression_objective.hpp"
 #include "xentropy_objective.hpp"
 
 namespace LightGBM {

src/objective/rank_objective.hpp

 #ifndef LIGHTGBM_OBJECTIVE_RANK_OBJECTIVE_HPP_
 #define LIGHTGBM_OBJECTIVE_RANK_OBJECTIVE_HPP_
 
-#include <LightGBM/objective_function.h>
 #include <LightGBM/metric.h>
+#include <LightGBM/objective_function.h>
 
+#include <limits>
+#include <string>
+#include <algorithm>
+#include <cmath>
 #include <cstdio>
 #include <cstring>
-#include <cmath>
-
 #include <vector>
-#include <algorithm>
-#include <limits>
 
 namespace LightGBM {
 /*!

src/objective/regression_objective.hpp

 #ifndef LIGHTGBM_OBJECTIVE_REGRESSION_OBJECTIVE_HPP_
 #define LIGHTGBM_OBJECTIVE_REGRESSION_OBJECTIVE_HPP_
 
-#include <LightGBM/objective_function.h>
 #include <LightGBM/meta.h>
-
+#include <LightGBM/objective_function.h>
 #include <LightGBM/utils/array_args.h>
 
+#include <string>
+#include <algorithm>
+#include <vector>
+
 namespace LightGBM {
 
 #define PercentileFun(T, data_reader, cnt_data, alpha) {\

src/objective/xentropy_objective.hpp

 #ifndef LIGHTGBM_OBJECTIVE_XENTROPY_OBJECTIVE_HPP_
 #define LIGHTGBM_OBJECTIVE_XENTROPY_OBJECTIVE_HPP_
 
-#include <LightGBM/objective_function.h>
 #include <LightGBM/meta.h>
-
+#include <LightGBM/objective_function.h>
 #include <LightGBM/utils/common.h>
 
-#include <cstring>
+#include <string>
+#include <algorithm>
 #include <cmath>
+#include <cstring>
+#include <vector>
 
 /*
  * Implements gradients and hessians for the following point losses.

src/treelearner/data_parallel_tree_learner.cpp

-#include "parallel_tree_learner.h"
-
 #include <cstring>
-
 #include <tuple>
 #include <vector>
 
+#include "parallel_tree_learner.h"
+
 namespace LightGBM {
 
 template <typename TREELEARNER_T>

src/treelearner/data_partition.hpp

 #ifndef LIGHTGBM_TREELEARNER_DATA_PARTITION_HPP_
 #define LIGHTGBM_TREELEARNER_DATA_PARTITION_HPP_
 
-#include <LightGBM/meta.h>
 #include <LightGBM/dataset.h>
-
+#include <LightGBM/meta.h>
 #include <LightGBM/utils/openmp_wrapper.h>
 
+#include <algorithm>
 #include <cstring>
-
 #include <vector>
 
 namespace LightGBM {

src/treelearner/feature_histogram.hpp

 #ifndef LIGHTGBM_TREELEARNER_FEATURE_HISTOGRAM_HPP_
 #define LIGHTGBM_TREELEARNER_FEATURE_HISTOGRAM_HPP_
 
-#include "split_info.hpp"
-
-#include <LightGBM/utils/array_args.h>
 #include <LightGBM/dataset.h>
+#include <LightGBM/utils/array_args.h>
 
-#include <cstring>
+#include <algorithm>
 #include <cmath>
+#include <cstring>
+#include <memory>
+#include <utility>
+#include <vector>
+
+#include "split_info.hpp"
 
 namespace LightGBM {
 

src/treelearner/feature_parallel_tree_learner.cpp

-#include "parallel_tree_learner.h"
-
 #include <cstring>
-
 #include <vector>
 
+#include "parallel_tree_learner.h"
+
 namespace LightGBM {
 
 

src/treelearner/gpu_tree_learner.cpp

 #ifdef USE_GPU
+
 #include "gpu_tree_learner.h"
-#include "../io/dense_bin.hpp"
-#include "../io/dense_nbits_bin.hpp"
 
-#include <LightGBM/utils/array_args.h>
-#include <LightGBM/network.h>
 #include <LightGBM/bin.h>
+#include <LightGBM/network.h>
+#include <LightGBM/utils/array_args.h>
 
 #include <algorithm>
-#include <vector>
 
+#include "../io/dense_bin.hpp"
+#include "../io/dense_nbits_bin.hpp"
 
 #define GPU_DEBUG 0