reworked includes in source files (#2066)

* added all necessary includes - fixed build/include_what_you_use error

* fixed the order of includes (build/include_order)

include/LightGBM/utils/log.h

 #ifndef LIGHTGBM_UTILS_LOG_H_
 #define LIGHTGBM_UTILS_LOG_H_
 
-#include <iostream>
+#include <string>
+#include <cstdarg>
 #include <cstdio>
 #include <cstdlib>
-#include <cstdarg>
 #include <cstring>
 #include <exception>
+#include <iostream>
 #include <stdexcept>
 
 namespace LightGBM {

include/LightGBM/utils/openmp_wrapper.h

@@ -3,12 +3,13 @@
 #ifdef _OPENMP
 
 #include <omp.h>
+#include <LightGBM/utils/log.h>
+
 #include <exception>
-#include <stdexcept>
+#include <memory>
 #include <mutex>
+#include <stdexcept>
 #include <vector>
-#include <memory>
-#include "log.h"
 
 class ThreadExceptionHelper {
  public:

include/LightGBM/utils/pipeline_reader.h

 #ifndef LIGHTGBM_UTILS_PIPELINE_READER_H_
 #define LIGHTGBM_UTILS_PIPELINE_READER_H_
 
+#include <LightGBM/utils/file_io.h>
 #include <LightGBM/utils/log.h>
 
+#include <algorithm>
 #include <cstdio>
-
 #include <functional>
-#include <thread>
 #include <memory>
-#include <algorithm>
+#include <thread>
+#include <utility>
 #include <vector>
-#include "file_io.h"
 
 namespace LightGBM {
 

include/LightGBM/utils/random.h

@@ -2,10 +2,9 @@
 #define LIGHTGBM_UTILS_RANDOM_H_
 
 #include <cstdint>
-
 #include <random>
-#include <vector>
 #include <set>
+#include <vector>
 
 namespace LightGBM {
 

include/LightGBM/utils/text_reader.h

 #ifndef LIGHTGBM_UTILS_TEXT_READER_H_
 #define LIGHTGBM_UTILS_TEXT_READER_H_
 
-#include <LightGBM/utils/pipeline_reader.h>
 #include <LightGBM/utils/log.h>
+#include <LightGBM/utils/pipeline_reader.h>
 #include <LightGBM/utils/random.h>
 
+#include <string>
 #include <cstdio>
+#include <functional>
 #include <sstream>
-
 #include <vector>
-#include <string>
-#include <functional>
 
 namespace LightGBM {
 

include/LightGBM/utils/threading.h

@@ -3,8 +3,8 @@
 
 #include <LightGBM/utils/openmp_wrapper.h>
 
-#include <vector>
 #include <functional>
+#include <vector>
 
 namespace LightGBM {
 

src/application/application.cpp

 #include <LightGBM/application.h>
 
-#include <LightGBM/utils/common.h>
-#include <LightGBM/utils/text_reader.h>
-
-#include <LightGBM/network.h>
+#include <LightGBM/boosting.h>
 #include <LightGBM/dataset.h>
 #include <LightGBM/dataset_loader.h>
-#include <LightGBM/boosting.h>
+#include <LightGBM/metric.h>
+#include <LightGBM/network.h>
 #include <LightGBM/objective_function.h>
 #include <LightGBM/prediction_early_stop.h>
-#include <LightGBM/metric.h>
-
-#include "predictor.hpp"
-
+#include <LightGBM/utils/common.h>
 #include <LightGBM/utils/openmp_wrapper.h>
+#include <LightGBM/utils/text_reader.h>
 
+#include <string>
+#include <chrono>
 #include <cstdio>
 #include <ctime>
-
-#include <chrono>
 #include <fstream>
 #include <sstream>
-#include <string>
 #include <utility>
-#include <vector>
+
+#include "predictor.hpp"
 
 namespace LightGBM {
 

src/application/predictor.hpp

 #ifndef LIGHTGBM_PREDICTOR_HPP_
 #define LIGHTGBM_PREDICTOR_HPP_
 
-#include <LightGBM/meta.h>
 #include <LightGBM/boosting.h>
-#include <LightGBM/utils/text_reader.h>
 #include <LightGBM/dataset.h>
-
+#include <LightGBM/meta.h>
 #include <LightGBM/utils/openmp_wrapper.h>
+#include <LightGBM/utils/text_reader.h>
 
-#include <map>
-#include <cstring>
+#include <string>
 #include <cstdio>
-#include <vector>
-#include <utility>
+#include <cstring>
 #include <functional>
-#include <string>
+#include <map>
 #include <memory>
+#include <unordered_map>
+#include <utility>
+#include <vector>
 
 namespace LightGBM {
 

src/boosting/boosting.cpp

 #include <LightGBM/boosting.h>
-#include "gbdt.h"
+
 #include "dart.hpp"
+#include "gbdt.h"
 #include "goss.hpp"
 #include "rf.hpp"
 

src/boosting/dart.hpp

@@ -2,13 +2,15 @@
 #define LIGHTGBM_BOOSTING_DART_H_
 
 #include <LightGBM/boosting.h>
-#include "score_updater.hpp"
-#include "gbdt.h"
 
-#include <cstdio>
-#include <vector>
 #include <string>
+#include <algorithm>
+#include <cstdio>
 #include <fstream>
+#include <vector>
+
+#include "gbdt.h"
+#include "score_updater.hpp"
 
 namespace LightGBM {
 /*!

src/boosting/gbdt.cpp

 #include "gbdt.h"
 
-#include <LightGBM/utils/openmp_wrapper.h>
-
-#include <LightGBM/utils/common.h>
-#include <LightGBM/objective_function.h>
 #include <LightGBM/metric.h>
-#include <LightGBM/prediction_early_stop.h>
 #include <LightGBM/network.h>
+#include <LightGBM/objective_function.h>
+#include <LightGBM/prediction_early_stop.h>
+#include <LightGBM/utils/common.h>
+#include <LightGBM/utils/openmp_wrapper.h>
 
+#include <chrono>
 #include <ctime>
-
 #include <sstream>
-#include <chrono>
-#include <string>
-#include <vector>
-#include <utility>
 
 namespace LightGBM {
 

src/boosting/gbdt.h

@@ -4,17 +4,20 @@
 #include <LightGBM/boosting.h>
 #include <LightGBM/objective_function.h>
 #include <LightGBM/prediction_early_stop.h>
-#include <LightGBM/json11.hpp>
-
-#include "score_updater.hpp"
 
-#include <cstdio>
-#include <vector>
 #include <string>
+#include <algorithm>
+#include <cstdio>
 #include <fstream>
+#include <map>
 #include <memory>
 #include <mutex>
-#include <map>
+#include <unordered_map>
+#include <utility>
+#include <vector>
+
+#include <LightGBM/json11.hpp>
+#include "score_updater.hpp"
 
 using namespace json11;
 

src/boosting/gbdt_model_text.cpp

-#include "gbdt.h"
-
-#include <LightGBM/utils/common.h>
-#include <LightGBM/objective_function.h>
 #include <LightGBM/metric.h>
+#include <LightGBM/objective_function.h>
+#include <LightGBM/utils/common.h>
 
-#include <sstream>
 #include <string>
+#include <sstream>
 #include <vector>
 
+#include "gbdt.h"
+
 namespace LightGBM {
 
 const std::string kModelVersion = "v2";

src/boosting/gbdt_prediction.cpp

-#include "gbdt.h"
-
-#include <LightGBM/utils/openmp_wrapper.h>
 #include <LightGBM/objective_function.h>
 #include <LightGBM/prediction_early_stop.h>
+#include <LightGBM/utils/openmp_wrapper.h>
+
+#include "gbdt.h"
 
 namespace LightGBM {
 

src/boosting/goss.hpp

 #ifndef LIGHTGBM_BOOSTING_GOSS_H_
 #define LIGHTGBM_BOOSTING_GOSS_H_
 
+#include <LightGBM/boosting.h>
 #include <LightGBM/utils/array_args.h>
 #include <LightGBM/utils/log.h>
 #include <LightGBM/utils/openmp_wrapper.h>
-#include <LightGBM/boosting.h>
-
-#include "score_updater.hpp"
-#include "gbdt.h"
 
-#include <cstdio>
-#include <vector>
 #include <string>
-#include <fstream>
-#include <chrono>
 #include <algorithm>
+#include <chrono>
+#include <cstdio>
+#include <fstream>
+#include <vector>
+
+#include "gbdt.h"
+#include "score_updater.hpp"
 
 namespace LightGBM {
 

src/boosting/prediction_early_stop.cpp

 #include <LightGBM/prediction_early_stop.h>
+
 #include <LightGBM/utils/log.h>
 
+#include <limits>
 #include <algorithm>
-#include <vector>
 #include <cmath>
-#include <limits>
+#include <vector>
 
 namespace {
 

src/boosting/rf.hpp

@@ -3,13 +3,16 @@
 
 #include <LightGBM/boosting.h>
 #include <LightGBM/metric.h>
-#include "score_updater.hpp"
-#include "gbdt.h"
 
-#include <cstdio>
-#include <vector>
 #include <string>
+#include <cstdio>
 #include <fstream>
+#include <memory>
+#include <utility>
+#include <vector>
+
+#include "gbdt.h"
+#include "score_updater.hpp"
 
 namespace LightGBM {
 /*!

src/boosting/score_updater.hpp

 #ifndef LIGHTGBM_BOOSTING_SCORE_UPDATER_HPP_
 #define LIGHTGBM_BOOSTING_SCORE_UPDATER_HPP_
 
-
-#include <LightGBM/utils/openmp_wrapper.h>
-#include <LightGBM/meta.h>
 #include <LightGBM/dataset.h>
+#include <LightGBM/meta.h>
 #include <LightGBM/tree.h>
 #include <LightGBM/tree_learner.h>
+#include <LightGBM/utils/openmp_wrapper.h>
 
 #include <cstring>
+#include <vector>
 
 namespace LightGBM {
 /*!

src/c_api.cpp

 #include <LightGBM/c_api.h>
 
-#include <LightGBM/utils/openmp_wrapper.h>
-#include <LightGBM/utils/common.h>
-#include <LightGBM/utils/random.h>
-#include <LightGBM/utils/threading.h>
-#include <LightGBM/utils/log.h>
-#include <LightGBM/dataset_loader.h>
-#include <LightGBM/dataset.h>
 #include <LightGBM/boosting.h>
-#include <LightGBM/objective_function.h>
-#include <LightGBM/metric.h>
 #include <LightGBM/config.h>
-#include <LightGBM/prediction_early_stop.h>
+#include <LightGBM/dataset.h>
+#include <LightGBM/dataset_loader.h>
+#include <LightGBM/metric.h>
 #include <LightGBM/network.h>
+#include <LightGBM/objective_function.h>
+#include <LightGBM/prediction_early_stop.h>
+#include <LightGBM/utils/common.h>
+#include <LightGBM/utils/log.h>
+#include <LightGBM/utils/openmp_wrapper.h>
+#include <LightGBM/utils/random.h>
+#include <LightGBM/utils/threading.h>
 
-#include <cstdio>
-#include <vector>
 #include <string>
-#include <cstring>
+#include <cstdio>
+#include <functional>
 #include <memory>
-#include <stdexcept>
 #include <mutex>
-#include <functional>
+#include <stdexcept>
+#include <vector>
 
-#include "./application/predictor.hpp"
+#include "application/predictor.hpp"
 
 namespace LightGBM {
 

src/io/bin.cpp

@@ -3,18 +3,15 @@
 #include <LightGBM/utils/common.h>
 #include <LightGBM/utils/file_io.h>
 
-#include "dense_bin.hpp"
-#include "dense_nbits_bin.hpp"
-#include "sparse_bin.hpp"
-#include "ordered_sparse_bin.hpp"
-
+#include <algorithm>
 #include <cmath>
-#include <cstring>
 #include <cstdint>
+#include <cstring>
 
-#include <limits>
-#include <vector>
-#include <algorithm>
+#include "dense_bin.hpp"
+#include "dense_nbits_bin.hpp"
+#include "ordered_sparse_bin.hpp"
+#include "sparse_bin.hpp"
 
 namespace LightGBM {