Unverified Commit 3db7c1b7 authored by James Lamb's avatar James Lamb Committed by GitHub
Browse files

[R-package] remove Makefile hack in install.libs.R (#3528)

parent 35d6ba6f
......@@ -216,29 +216,6 @@ if (!makefiles_already_generated) {
.run_shell_command("cmake", c(cmake_args, ".."))
}
# R CMD check complains about the .NOTPARALLEL directive created in the cmake
# Makefile. We don't need it here anyway since targets are built serially, so trying
# to remove it with this hack
generated_makefile <- file.path(
build_dir
, "Makefile"
)
if (file.exists(generated_makefile)) {
makefile_txt <- readLines(
con = generated_makefile
)
makefile_txt <- gsub(
pattern = ".*NOTPARALLEL.*"
, replacement = ""
, x = makefile_txt
)
writeLines(
text = makefile_txt
, con = generated_makefile
, sep = "\n"
)
}
# build the library
message("Building lib_lightgbm")
.run_shell_command(build_cmd, build_args)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment