"docs/vscode:/vscode.git/clone" did not exist on "924f880d4da3af3d376ed8d834e613192071fee4"
Unverified Commit b6945310 authored by Ryan Russell's avatar Ryan Russell Committed by GitHub
Browse files

refactor: `custom_init_isort` readability fixups (#631)


Signed-off-by: default avatarRyan Russell <git@ryanrussell.org>
Signed-off-by: default avatarRyan Russell <git@ryanrussell.org>
parent b671cb09
...@@ -200,7 +200,7 @@ def sort_imports(file, check_only=True): ...@@ -200,7 +200,7 @@ def sort_imports(file, check_only=True):
indent = get_indent(block_lines[1]) indent = get_indent(block_lines[1])
# Slit the internal block into blocks of indent level 1. # Slit the internal block into blocks of indent level 1.
internal_blocks = split_code_in_indented_blocks(internal_block_code, indent_level=indent) internal_blocks = split_code_in_indented_blocks(internal_block_code, indent_level=indent)
# We have two categories of import key: list or _import_structu[key].append/extend # We have two categories of import key: list or _import_structure[key].append/extend
pattern = _re_direct_key if "_import_structure" in block_lines[0] else _re_indirect_key pattern = _re_direct_key if "_import_structure" in block_lines[0] else _re_indirect_key
# Grab the keys, but there is a trap: some lines are empty or just comments. # Grab the keys, but there is a trap: some lines are empty or just comments.
keys = [(pattern.search(b).groups()[0] if pattern.search(b) is not None else None) for b in internal_blocks] keys = [(pattern.search(b).groups()[0] if pattern.search(b) is not None else None) for b in internal_blocks]
...@@ -210,17 +210,17 @@ def sort_imports(file, check_only=True): ...@@ -210,17 +210,17 @@ def sort_imports(file, check_only=True):
# We reorder the blocks by leaving empty lines/comments as they were and reorder the rest. # We reorder the blocks by leaving empty lines/comments as they were and reorder the rest.
count = 0 count = 0
reorderded_blocks = [] reordered_blocks = []
for i in range(len(internal_blocks)): for i in range(len(internal_blocks)):
if keys[i] is None: if keys[i] is None:
reorderded_blocks.append(internal_blocks[i]) reordered_blocks.append(internal_blocks[i])
else: else:
block = sort_objects_in_import(internal_blocks[sorted_indices[count]]) block = sort_objects_in_import(internal_blocks[sorted_indices[count]])
reorderded_blocks.append(block) reordered_blocks.append(block)
count += 1 count += 1
# And we put our main block back together with its first and last line. # And we put our main block back together with its first and last line.
main_blocks[block_idx] = "\n".join(block_lines[:line_idx] + reorderded_blocks + [block_lines[-1]]) main_blocks[block_idx] = "\n".join(block_lines[:line_idx] + reordered_blocks + [block_lines[-1]])
if code != "\n".join(main_blocks): if code != "\n".join(main_blocks):
if check_only: if check_only:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment