Unverified Commit 437b6e70 authored by gilbertlee-amd's avatar gilbertlee-amd Committed by GitHub
Browse files

v1.40 Fixing USE_XCC_FILTER for preset configurations (#72)

parent 7a1dbd6a
...@@ -3,6 +3,11 @@ ...@@ -3,6 +3,11 @@
Documentation for TransferBench is available at Documentation for TransferBench is available at
[https://rocm.docs.amd.com/projects/TransferBench](https://rocm.docs.amd.com/projects/TransferBench). [https://rocm.docs.amd.com/projects/TransferBench](https://rocm.docs.amd.com/projects/TransferBench).
## v1.40
### Fixes
* Fixing XCC defaulting to 0 instead of random for preset configs, ignoring XCC_PREF_TABLE
## v1.39 ## v1.39
### Additions ### Additions
......
...@@ -1599,6 +1599,7 @@ void RunPeerToPeerBenchmarks(EnvVars const& ev, size_t N) ...@@ -1599,6 +1599,7 @@ void RunPeerToPeerBenchmarks(EnvVars const& ev, size_t N)
transfers[0].numSrcs = transfers[0].numDsts = 1; transfers[0].numSrcs = transfers[0].numDsts = 1;
transfers[0].exeType = IsGpuType(ev.useRemoteRead ? dstType : srcType) ? gpuExeType : EXE_CPU; transfers[0].exeType = IsGpuType(ev.useRemoteRead ? dstType : srcType) ? gpuExeType : EXE_CPU;
transfers[0].exeIndex = (ev.useRemoteRead ? dstIndex : srcIndex); transfers[0].exeIndex = (ev.useRemoteRead ? dstIndex : srcIndex);
transfers[0].exeSubIndex = -1;
transfers[0].numSubExecs = IsGpuType(transfers[0].exeType) ? ev.numGpuSubExecs : ev.numCpuSubExecs; transfers[0].numSubExecs = IsGpuType(transfers[0].exeType) ? ev.numGpuSubExecs : ev.numCpuSubExecs;
// DST -> SRC // DST -> SRC
...@@ -1612,6 +1613,7 @@ void RunPeerToPeerBenchmarks(EnvVars const& ev, size_t N) ...@@ -1612,6 +1613,7 @@ void RunPeerToPeerBenchmarks(EnvVars const& ev, size_t N)
transfers[1].dstIndex.push_back(srcIndex); transfers[1].dstIndex.push_back(srcIndex);
transfers[1].exeType = IsGpuType(ev.useRemoteRead ? srcType : dstType) ? gpuExeType : EXE_CPU; transfers[1].exeType = IsGpuType(ev.useRemoteRead ? srcType : dstType) ? gpuExeType : EXE_CPU;
transfers[1].exeIndex = (ev.useRemoteRead ? srcIndex : dstIndex); transfers[1].exeIndex = (ev.useRemoteRead ? srcIndex : dstIndex);
transfers[1].exeSubIndex = -1;
transfers[1].numSubExecs = IsGpuType(transfers[1].exeType) ? ev.numGpuSubExecs : ev.numCpuSubExecs; transfers[1].numSubExecs = IsGpuType(transfers[1].exeType) ? ev.numGpuSubExecs : ev.numCpuSubExecs;
} }
...@@ -1819,6 +1821,7 @@ void RunScalingBenchmark(EnvVars const& ev, size_t N, int const exeIndex, int co ...@@ -1819,6 +1821,7 @@ void RunScalingBenchmark(EnvVars const& ev, size_t N, int const exeIndex, int co
transfers[0].numDsts = 1; transfers[0].numDsts = 1;
transfers[0].exeType = EXE_GPU_GFX; transfers[0].exeType = EXE_GPU_GFX;
transfers[0].exeIndex = exeIndex; transfers[0].exeIndex = exeIndex;
transfers[0].exeSubIndex = -1;
transfers[0].srcType.resize(1, MEM_GPU); transfers[0].srcType.resize(1, MEM_GPU);
transfers[0].dstType.resize(1, MEM_GPU); transfers[0].dstType.resize(1, MEM_GPU);
transfers[0].srcIndex.resize(1); transfers[0].srcIndex.resize(1);
...@@ -1887,6 +1890,7 @@ void RunAllToAllBenchmark(EnvVars const& ev, size_t const numBytesPerTransfer, i ...@@ -1887,6 +1890,7 @@ void RunAllToAllBenchmark(EnvVars const& ev, size_t const numBytesPerTransfer, i
transfer.numSrcs = 1; transfer.numSrcs = 1;
transfer.numDsts = 1; transfer.numDsts = 1;
transfer.exeType = EXE_GPU_GFX; transfer.exeType = EXE_GPU_GFX;
transfer.exeSubIndex = -1;
transfer.srcType.resize(1, ev.useFineGrain ? MEM_GPU_FINE : MEM_GPU); transfer.srcType.resize(1, ev.useFineGrain ? MEM_GPU_FINE : MEM_GPU);
transfer.dstType.resize(1, ev.useFineGrain ? MEM_GPU_FINE : MEM_GPU); transfer.dstType.resize(1, ev.useFineGrain ? MEM_GPU_FINE : MEM_GPU);
transfer.srcIndex.resize(1); transfer.srcIndex.resize(1);
...@@ -2459,6 +2463,7 @@ void RunSweepPreset(EnvVars const& ev, size_t const numBytesPerTransfer, int con ...@@ -2459,6 +2463,7 @@ void RunSweepPreset(EnvVars const& ev, size_t const numBytesPerTransfer, int con
transfer.srcIndex = {possibleTransfers[value].srcIndex}; transfer.srcIndex = {possibleTransfers[value].srcIndex};
transfer.exeType = possibleTransfers[value].exeType; transfer.exeType = possibleTransfers[value].exeType;
transfer.exeIndex = possibleTransfers[value].exeIndex; transfer.exeIndex = possibleTransfers[value].exeIndex;
transfer.exeSubIndex = -1;
transfer.dstType = {possibleTransfers[value].dstType}; transfer.dstType = {possibleTransfers[value].dstType};
transfer.dstIndex = {possibleTransfers[value].dstIndex}; transfer.dstIndex = {possibleTransfers[value].dstIndex};
transfer.numSubExecs = IsGpuType(transfer.exeType) ? numGpuSubExecs : numCpuSubExecs; transfer.numSubExecs = IsGpuType(transfer.exeType) ? numGpuSubExecs : numCpuSubExecs;
......
...@@ -29,7 +29,7 @@ THE SOFTWARE. ...@@ -29,7 +29,7 @@ THE SOFTWARE.
#include "Compatibility.hpp" #include "Compatibility.hpp"
#include "Kernels.hpp" #include "Kernels.hpp"
#define TB_VERSION "1.39" #define TB_VERSION "1.40"
extern char const MemTypeStr[]; extern char const MemTypeStr[];
extern char const ExeTypeStr[]; extern char const ExeTypeStr[];
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment