Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
norm
vllm
Commits
cb08cd0d
Unverified
Commit
cb08cd0d
authored
Nov 16, 2023
by
Simon Mo
Committed by
GitHub
Nov 16, 2023
Browse files
[Minor] Fix duplication of ignored seq group in engine step (#1666)
parent
2a2c135b
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
28 additions
and
1 deletion
+28
-1
tests/test_regression.py
tests/test_regression.py
+27
-0
vllm/engine/llm_engine.py
vllm/engine/llm_engine.py
+1
-1
No files found.
tests/test_regression.py
0 → 100644
View file @
cb08cd0d
"""Containing tests that check for regressions in vLLM's behavior.
It should include tests that are reported by users and making sure they
will never happen again.
"""
from
vllm
import
LLM
,
SamplingParams
def
test_duplicated_ignored_sequence_group
():
"""https://github.com/vllm-project/vllm/issues/1655"""
sampling_params
=
SamplingParams
(
temperature
=
0.01
,
top_p
=
0.1
,
max_tokens
=
256
)
llm
=
LLM
(
model
=
"facebook/opt-125m"
,
max_num_batched_tokens
=
4096
,
tensor_parallel_size
=
1
)
prompts
=
[
"This is a short prompt"
,
"This is a very long prompt "
*
1000
]
outputs
=
llm
.
generate
(
prompts
,
sampling_params
=
sampling_params
)
assert
len
(
prompts
)
==
len
(
outputs
)
if
__name__
==
"__main__"
:
import
pytest
pytest
.
main
([
__file__
])
vllm/engine/llm_engine.py
View file @
cb08cd0d
...
...
@@ -567,7 +567,7 @@ class LLMEngine:
blocks_to_copy
=
scheduler_outputs
.
blocks_to_copy
,
)
return
self
.
_process_model_outputs
(
output
,
scheduler_outputs
)
+
ignored
return
self
.
_process_model_outputs
(
output
,
scheduler_outputs
)
def
_log_system_stats
(
self
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment