Fix frequent deadlocks caused by summaries not depending on the save_state ops.

PiperOrigin-RevId: 172665358

Fix frequent deadlocks caused by summaries not depending on the save_state ops.
PiperOrigin-RevId: 172665358
fda7e6dc · Andrew M. Dai · 4b5a0801 · fda7e6dc
Commit fda7e6dc authored Oct 18, 2017 by Andrew M. Dai
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 4 deletions

research/adversarial_text/graphs.py research/adversarial_text/graphs.py +3 -4

No files found.
--- a/research/adversarial_text/graphs.py
+++ b/research/adversarial_text/graphs.py
@@ -189,11 +189,10 @@ class VatxtModel(object):
    tf.summary.scalar('adversarial_loss', adv_loss)

    total_loss = loss + adv_loss
-    tf.summary.scalar('total_classification_loss', total_loss)

    with tf.control_dependencies([inputs.save_state(next_state)]):
      total_loss = tf.identity(total_loss)
-
+      tf.summary.scalar('total_classification_loss', total_loss)
    return total_loss

  def language_model_graph(self, compute_loss=True):
@@ -419,12 +418,12 @@ class VatxtBidirModel(VatxtModel):
    tf.summary.scalar('adversarial_loss', adv_loss)

    total_loss = loss + adv_loss
-    tf.summary.scalar('total_classification_loss', total_loss)
+

    saves = [inp.save_state(state) for (inp, state) in zip(inputs, next_states)]
    with tf.control_dependencies(saves):
      total_loss = tf.identity(total_loss)
-
+      tf.summary.scalar('total_classification_loss', total_loss)
    return total_loss

  def language_model_graph(self, compute_loss=True):