skip bisection when it is not needed

4cdea1cc · Taylor Robie · d569b531 · 4cdea1cc
Commit 4cdea1cc authored Dec 27, 2018 by Taylor Robie
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

official/recommendation/data_pipeline.py official/recommendation/data_pipeline.py +4 -0

No files found.
--- a/official/recommendation/data_pipeline.py
+++ b/official/recommendation/data_pipeline.py
@@ -826,6 +826,10 @@ class BisectionDataConstructor(BaseDataConstructor):
        (neg_item_choice - self._total_negatives[right_index])
    )[use_shortcut]

+    if np.all(use_shortcut):
+      # The bisection code is ill-posed when there are no elements.
+      return output
+
    not_use_shortcut = np.logical_not(use_shortcut)
    left_index = left_index[not_use_shortcut]
    right_index = right_index[not_use_shortcut]