Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
gaoqiong
pybind11
Commits
f8d4aa47
Unverified
Commit
f8d4aa47
authored
Jan 11, 2022
by
Aaron Gokaslan
Committed by
GitHub
Jan 11, 2022
Browse files
Add clang-tidy readability checks for sus args (#3611)
parent
21911e12
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
1 deletion
+2
-1
.clang-tidy
.clang-tidy
+1
-0
tests/test_virtual_functions.cpp
tests/test_virtual_functions.cpp
+1
-1
No files found.
.clang-tidy
View file @
f8d4aa47
...
@@ -46,6 +46,7 @@ readability-simplify-subscript-expr,
...
@@ -46,6 +46,7 @@ readability-simplify-subscript-expr,
readability-static-accessed-through-instance,
readability-static-accessed-through-instance,
readability-static-definition-in-anonymous-namespace,
readability-static-definition-in-anonymous-namespace,
readability-string-compare,
readability-string-compare,
readability-suspicious-call-argument,
readability-uniqueptr-delete-release,
readability-uniqueptr-delete-release,
-bugprone-exception-escape,
-bugprone-exception-escape,
-bugprone-reserved-identifier,
-bugprone-reserved-identifier,
...
...
tests/test_virtual_functions.cpp
View file @
f8d4aa47
...
@@ -350,7 +350,7 @@ TEST_SUBMODULE(virtual_functions, m) {
...
@@ -350,7 +350,7 @@ TEST_SUBMODULE(virtual_functions, m) {
m
.
def
(
"add3"
,
[](
const
AdderBase
::
Data
&
first
,
const
AdderBase
::
Data
&
second
,
const
AdderBase
::
Data
&
third
,
m
.
def
(
"add3"
,
[](
const
AdderBase
::
Data
&
first
,
const
AdderBase
::
Data
&
second
,
const
AdderBase
::
Data
&
third
,
const
AdderBase
&
adder
,
const
AdderBase
::
DataVisitor
&
visitor
)
{
const
AdderBase
&
adder
,
const
AdderBase
::
DataVisitor
&
visitor
)
{
adder
(
first
,
second
,
[
&
]
(
const
AdderBase
::
Data
&
first_plus_second
)
{
adder
(
first
,
second
,
[
&
]
(
const
AdderBase
::
Data
&
first_plus_second
)
{
adder
(
first_plus_second
,
third
,
visitor
);
adder
(
first_plus_second
,
third
,
visitor
);
// NOLINT(readability-suspicious-call-argument)
});
});
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment