code cleanup according to comments.

src/CMakeLists.txt

@@ -18,7 +18,7 @@ add_library(migraphx
     generate.cpp
     instruction.cpp
     program.cpp
-    quantize_ins.cpp
+    quantize.cpp
     shape.cpp
     schedule.cpp
     pass_manager.cpp

src/include/migraphx/quantize_ins.hpp → src/include/migraphx/quantize.hpp

-#ifndef MIGRAPHX_GUARD_RTGLIB_QUANTIZE_INS_HPP
-#define MIGRAPHX_GUARD_RTGLIB_QUANTIZE_INS_HPP
+#ifndef MIGRAPHX_GUARD_RTGLIB_QUANTIZE_HPP
+#define MIGRAPHX_GUARD_RTGLIB_QUANTIZE_HPP
 
 #include <string>
 #include <vector>
@@ -12,7 +12,7 @@ inline namespace MIGRAPHX_INLINE_NS {
 
 struct program;
 
-void quantize_ins(program& prog, const std::vector<std::string>& ins_names);
+void quantize(program& prog, const std::vector<std::string>& ins_names);
 
 } // namespace MIGRAPHX_INLINE_NS
 } // namespace migraphx

src/py/migraphx_py.cpp

@@ -2,7 +2,7 @@
 #include <pybind11/pybind11.h>
 #include <pybind11/stl.h>
 #include <migraphx/program.hpp>
-#include <migraphx/quantize_ins.hpp>
+#include <migraphx/quantize.hpp>
 #include <migraphx/generate.hpp>
 #include <migraphx/cpu/target.hpp>
 #include <migraphx/stringutils.hpp>
@@ -182,7 +182,7 @@ PYBIND11_MODULE(migraphx, m)
     });
 
     m.def("generate_argument", &migraphx::generate_argument, py::arg("s"), py::arg("seed") = 0);
-    m.def("quantize_ins", &migraphx::quantize_ins);
+    m.def("quantize", &migraphx::quantize);
 
 #ifdef HAVE_GPU
     m.def("allocate_gpu", &migraphx::gpu::allocate_gpu, py::arg("s"), py::arg("host") = false);

src/quantize_ins.cpp → src/quantize.cpp

-#include <migraphx/quantize_ins.hpp>
+#include <migraphx/quantize.hpp>
 #include <migraphx/program.hpp>
 #include <migraphx/instruction.hpp>
 #include <migraphx/iterator_for.hpp>
 #include <migraphx/op/fp_conversion.hpp>
 #include <migraphx/stringutils.hpp>
+#include <migraphx/ranges.hpp>
 #include <utility>
 
 namespace migraphx {
@@ -46,13 +47,13 @@ instruction_ref insert_fp16(program& prog,
     return ins_fp16;
 }
 
-void quantize_ins(program& prog, const std::vector<std::string>& ins_names)
+void quantize(program& prog, const std::vector<std::string>& ins_names)
 {
     std::unordered_map<instruction_ref, instruction_ref> map_fp16;
     for(auto ins : iterator_for(prog))
     {
-        auto name_it = std::find(ins_names.begin(), ins_names.end(), ins->name());
-        if(name_it == ins_names.end())
+        // all indicates every instruction is converted
+        if ((not contains(ins_names, "all")) and (not contains(ins_names, ins->name())))
         {
             continue;
         }
@@ -106,7 +107,8 @@ void quantize_ins(program& prog, const std::vector<std::string>& ins_names)
                 }
             }
 
-            instruction::replace(ins, op, compute_shape(op, converted_inputs), converted_inputs);
+            prog.replace_instruction(ins, op, converted_inputs);
+            //instruction::replace(ins, op, compute_shape(op, converted_inputs), converted_inputs);
         }
     }
 }