Check tests

.clang-tidy

@@ -6,11 +6,11 @@ CheckOptions:
   - key:             readability-function-size.LineThreshold
     value:           '300'
   - key:             readability-function-size.NestingThreshold
-    value:           '8'
+    value:           '5'
   - key:             readability-function-size.ParameterThreshold
     value:           '10'
   - key:             readability-function-size.StatementThreshold
-    value:           '300'
+    value:           '150'
   - key:             readability-identifier-naming.Namespace
     value:           snake_case
   - key:             readability-identifier-naming.InlineNamespace

test/CMakeLists.txt

@@ -43,7 +43,7 @@ endfunction()
 
 function(add_test_executable TEST_NAME)
     add_executable (${TEST_NAME} EXCLUDE_FROM_ALL ${ARGN})
-    # clang_tidy_check(${TEST_NAME})
+    rocm_clang_tidy_check(${TEST_NAME})
     target_link_libraries(${TEST_NAME} ${CMAKE_THREAD_LIBS_INIT})
     # Cmake does not add flags correctly for gcc
     if(CMAKE_CXX_COMPILER_ID MATCHES "GNU") 

test/literal_test.cpp

@@ -12,7 +12,7 @@ void literal_test()
     EXPECT(rtg::literal{} != rtg::literal{2});
 
     rtg::literal l1{1};
-    rtg::literal l2 = l1;
+    rtg::literal l2 = l1; // NOLINT
     EXPECT(l1 == l2);
     EXPECT(l1.at<int>(0) == 1);
     EXPECT(!l1.empty());
@@ -38,7 +38,7 @@ void literal_os2()
     rtg::literal l{};
     std::stringstream ss;
     ss << l;
-    EXPECT(ss.str() == "");
+    EXPECT(ss.str().empty());
 }
 
 void literal_os3()

test/shape_test.cpp

@@ -5,7 +5,7 @@
 void test_shape_assign()
 {
     rtg::shape s1{rtg::shape::float_type, {100, 32, 8, 8}};
-    rtg::shape s2 = s1;
+    rtg::shape s2 = s1; // NOLINT
     EXPECT(s1 == s2);
     EXPECT(!(s1 != s2));
 }