Fix using the LD to embed files and enable by default when building shared libraries on linux

cmake/Embed.cmake

@@ -26,7 +26,11 @@ if(WIN32)
     set(EMBED_USE RC CACHE STRING "Use RC or CArrays to embed data files")
     set_property(CACHE EMBED_USE PROPERTY STRINGS "RC;CArrays")
 else()
+    if(BUILD_SHARED_LIBS)
+        set(EMBED_USE LD CACHE STRING "Use LD or CArrays to embed data files")
+    else()
         set(EMBED_USE CArrays CACHE STRING "Use LD or CArrays to embed data files")
+    endif()
     set_property(CACHE EMBED_USE PROPERTY STRINGS "LD;CArrays")
 endif()
 
@@ -199,7 +203,11 @@ function(add_embed_library EMBED_NAME)
     message(STATUS "Generating embedding library '${EMBED_NAME}'")
     generate_embed_source(${EMBED_NAME} ${EMBED_DIR} "${PARSE_RELATIVE}" SYMBOLS ${SYMBOLS} FILES ${PARSE_UNPARSED_ARGUMENTS})
     set(INTERNAL_EMBED_LIB embed_lib_${EMBED_NAME})
+    if(EMBED_USE STREQUAL "LD")
+        add_library(${INTERNAL_EMBED_LIB} STATIC ${EMBED_FILES} ${OUTPUT_FILES})
+    else()
         add_library(${INTERNAL_EMBED_LIB} OBJECT ${EMBED_FILES})
+    endif()
     if(EMBED_USE STREQUAL "CArrays")
         target_sources(${INTERNAL_EMBED_LIB} PRIVATE ${OUTPUT_FILES})
     endif()
@@ -207,9 +215,6 @@ function(add_embed_library EMBED_NAME)
     target_compile_options(${INTERNAL_EMBED_LIB} PRIVATE -Wno-reserved-identifier -Wno-extern-initializer -Wno-missing-variable-declarations)
     set_target_properties(${INTERNAL_EMBED_LIB} PROPERTIES POSITION_INDEPENDENT_CODE On)
     add_library(${EMBED_NAME} INTERFACE)
-    if(EMBED_USE STREQUAL "LD")
-        target_sources(${EMBED_NAME} INTERFACE ${OUTPUT_FILES})
-    endif()
     if(EMBED_USE STREQUAL "RC")
         target_link_libraries(${EMBED_NAME} INTERFACE $<TARGET_OBJECTS:${INTERNAL_EMBED_LIB}>)
     endif()