Commit 16bb5c56 authored by Paul's avatar Paul
Browse files

Some review fixes

parent c75fb295
...@@ -252,7 +252,7 @@ get_target_property(ROCBLAS_LOCATION roc::rocblas LOCATION) ...@@ -252,7 +252,7 @@ get_target_property(ROCBLAS_LOCATION roc::rocblas LOCATION)
check_library_exists(MIOpen "miopenHiddenSetConvolutionFindMode" "${MIOPEN_LOCATION}" HAS_FIND_MODE_API) check_library_exists(MIOpen "miopenHiddenSetConvolutionFindMode" "${MIOPEN_LOCATION}" HAS_FIND_MODE_API)
check_library_exists(MIOpen "miopenFindSolutions" "${MIOPEN_LOCATION}" HAS_FIND_2_API) check_library_exists(MIOpen "miopenFindSolutions" "${MIOPEN_LOCATION}" HAS_FIND_2_API)
# Beta API for automated GEMM tuning # Beta API for automated GEMM tuning
check_library_exists(roc::rocblas "rocblas_gemm_ex_get_solutions" "${ROCBLAS_LOCATION}" HAS_ROCBLAS_BETA_FEATURES_API) check_library_exists(roc::rocblas "rocblas_gemm_ex_get_solutions" "${ROCBLAS_LOCATION}" HAS_ROCBLAS_TUNING_BETA_FEATURE_API)
set(MIGRAPHX_USE_FIND_2_API "${HAS_FIND_2_API}" CACHE BOOL "") set(MIGRAPHX_USE_FIND_2_API "${HAS_FIND_2_API}" CACHE BOOL "")
...@@ -275,7 +275,7 @@ else() ...@@ -275,7 +275,7 @@ else()
message(STATUS "MIOpen does not have find mode api") message(STATUS "MIOpen does not have find mode api")
endif() endif()
if(HAS_ROCBLAS_BETA_FEATURES_API) if(HAS_ROCBLAS_TUNING_BETA_FEATURE_API)
target_compile_definitions(migraphx_gpu PUBLIC -DMIGRAPHX_USE_ROCBLAS_TUNING_API -DROCBLAS_BETA_FEATURES_API -DROCBLAS_NO_DEPRECATED_WARNINGS) target_compile_definitions(migraphx_gpu PUBLIC -DMIGRAPHX_USE_ROCBLAS_TUNING_API -DROCBLAS_BETA_FEATURES_API -DROCBLAS_NO_DEPRECATED_WARNINGS)
message(STATUS "MIGraphx is using Beta API of rocBLAS") message(STATUS "MIGraphx is using Beta API of rocBLAS")
else() else()
......
...@@ -564,7 +564,6 @@ int32_t gemm_finalize(context& ctx, ...@@ -564,7 +564,6 @@ int32_t gemm_finalize(context& ctx,
solution_idx = gemm_item.validate(ctx, input_shapes, solution_idx); solution_idx = gemm_item.validate(ctx, input_shapes, solution_idx);
} }
#else #else
// suppress compiler warnings
(void)ctx, (void)output_shape, (void)input_shapes; (void)ctx, (void)output_shape, (void)input_shapes;
(void)alpha, (void)beta, (void)compute_fp32; (void)alpha, (void)beta, (void)compute_fp32;
#endif #endif
...@@ -600,7 +599,6 @@ int32_t gemm_finalize(context& ctx, ...@@ -600,7 +599,6 @@ int32_t gemm_finalize(context& ctx,
solution_idx = gemm_item.validate(ctx, input_shapes, solution_idx); solution_idx = gemm_item.validate(ctx, input_shapes, solution_idx);
} }
#else #else
// suppress compiler warnings
(void)ctx, (void)output_shape, (void)input_shapes; (void)ctx, (void)output_shape, (void)input_shapes;
(void)alpha, (void)beta, (void)compute_fp32; (void)alpha, (void)beta, (void)compute_fp32;
#endif #endif
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment