Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
gaoqiong
lm-evaluation-harness
Commits
b0585de4
Commit
b0585de4
authored
Oct 05, 2020
by
Leo Gao
Browse files
Don't make Dataset.download abstract
It's ok if subclasses don't implement download, no-op default is ok
parent
a5c48976
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
0 additions
and
1 deletion
+0
-1
lm_eval/base.py
lm_eval/base.py
+0
-1
No files found.
lm_eval/base.py
View file @
b0585de4
...
@@ -55,7 +55,6 @@ class LM(abc.ABC):
...
@@ -55,7 +55,6 @@ class LM(abc.ABC):
class
Dataset
(
abc
.
ABC
):
class
Dataset
(
abc
.
ABC
):
@
abc
.
abstractmethod
def
download
(
self
):
def
download
(
self
):
"""Downloads the task dataset if necessary"""
"""Downloads the task dataset if necessary"""
pass
pass
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment