convert all enabled tasks to use best_download for better download robustness

lm_eval/tasks/coqa.py

@@ -4,6 +4,7 @@ import transformers.data.metrics.squad_metrics as squad_metrics
 from lm_eval.base import Task, rf, mean
 from ..utils import sh
 from itertools import zip_longest
+from best_download import download_file
 
 
 class CoQA(Task):
@@ -14,10 +15,9 @@ class CoQA(Task):
         coqa_dev_filepath = 'data/coqa/coqa-dev-v1.0.json'
 
         sh ("""mkdir -p data/coqa""")
-        if not os.path.exists(coqa_train_filepath):
-            sh ("""wget http://downloads.cs.stanford.edu/nlp/data/coqa/coqa-train-v1.0.json -O """ + coqa_train_filepath)
-        if not os.path.exists(coqa_dev_filepath):
-            sh ("""wget http://downloads.cs.stanford.edu/nlp/data/coqa/coqa-dev-v1.0.json -O """ + coqa_dev_filepath)
+
+        download_file("http://downloads.cs.stanford.edu/nlp/data/coqa/coqa-train-v1.0.json", coqa_train_filepath, "b0fdb2bc1bd38dd3ca2ce5fa2ac3e02c6288ac914f241ac409a655ffb6619fa6")
+        download_file("http://downloads.cs.stanford.edu/nlp/data/coqa/coqa-dev-v1.0.json", coqa_dev_filepath, "dfa367a9733ce53222918d0231d9b3bedc2b8ee831a2845f62dfc70701f2540a")
 
     def has_training_docs(self):
         return True

lm_eval/tasks/hendrycks_ethics.py

@@ -7,6 +7,7 @@ from lm_eval.base import Task, rf
 from lm_eval.metrics import mean
 from lm_eval.utils import sh
 from .common import yesno
+from best_download import download_file
 
 """
 NOTE: The reported "group" accuracies for the Deontology, Justice, and Virtue
@@ -17,12 +18,13 @@ of the paper.
 
 class Ethics(Task):
     def download(self):
-        if not os.path.exists('data/ethics'):
+        if not os.path.exists('data/ethics/done'):
+            sh("mkdir -p data")
+            download_file("https://people.eecs.berkeley.edu/~hendrycks/ethics.tar", "data/ethics.tar", "40acbf1ac0da79a2aabef394d58889136b8d38b05be09482006de2453fb06333")
             sh("""
-                mkdir -p data
-                wget https://people.eecs.berkeley.edu/~hendrycks/ethics.tar -P data/
             tar -xf data/ethics.tar -C data/
             rm data/ethics.tar
+            touch data/ethics/done
             """)
 
     def has_training_docs(self):

lm_eval/tasks/hendrycks_math.py

@@ -4,6 +4,7 @@ from lm_eval.utils import sh
 from lm_eval.metrics import mean
 from lm_eval.base import Task, rf
 from pathlib import Path
+from best_download import download_file
 
 
 class Math(Task):
@@ -15,12 +16,13 @@ class Math(Task):
     DATASET_PATH = Path('data/MATH')
 
     def download(self):
-        if not self.DATASET_PATH.exists():
+        if not (self.DATASET_PATH / 'done').exists():
+            sh(f"mkdir -p {self.DATASET_PATH}")
+            download_file("https://people.eecs.berkeley.edu/~hendrycks/MATH.tar.gz", f"{self.DATASET_PATH}.tar.gz", "e867c0df3e45e5f8219296d12dd4579d91fe313de8dc020ed17382e84f64c2f7")
             sh(f"""
-            mkdir -p {self.DATASET_PATH}
-            wget https://people.eecs.berkeley.edu/~hendrycks/MATH.tar.gz -P data/
             tar -xf {self.DATASET_PATH}.tar.gz -C data/
             rm {self.DATASET_PATH}.tar.gz
+            touch {self.DATASET_PATH / 'done'}
             """)
 
     @abc.abstractmethod

lm_eval/tasks/hendrycks_test.py

@@ -3,6 +3,7 @@ import random
 from lm_eval.base import MultipleChoiceTask
 from ..utils import sh
 from pathlib import Path
+from best_download import download_file
 
 SUBJECTS = ['abstract_algebra', 'anatomy', 'astronomy', 'business_ethics', 'clinical_knowledge', 'college_biology',
             'college_chemistry', 'college_computer_science', 'college_mathematics', 'college_medicine', 'college_physics',
@@ -42,13 +43,14 @@ class GeneralHendrycksTest(MultipleChoiceTask):
         super().__init__()
 
     def download(self):
-        if not self.DATASET_PATH.exists():
+        if not (self.DATASET_PATH / 'done').exists():
+            sh("mkdir -p data")
+            download_file("https://people.eecs.berkeley.edu/~hendrycks/data.tar", "data/data.tar", "78a804365a59028188fb19bd1adcadc5e0c260b220a9d8b2e33a5ea7d5fbe3b4")
             sh("""
-                mkdir -p data
-                wget -c https://people.eecs.berkeley.edu/~hendrycks/data.tar -P data/
             tar -xf data/data.tar -C data/
             rm data/data.tar
             mv data/data data/hendrycksTest
+            touch data/hendrycksTest/done
             """)
 
     def has_training_docs(self):

lm_eval/tasks/lambada.py

@@ -9,12 +9,16 @@ class LAMBADA(Task):
     VERSION = 0
     def download(self):
         sh("mkdir -p data/lambada")
+        try:
+            download_file(
+                "http://eaidata.bmk.sh/data/lambada_test.jsonl", 
+                "data/lambada/lambada_test.jsonl", 
+                "4aa8d02cd17c719165fc8a7887fddd641f43fcafa4b1c806ca8abc31fabdb226"
+            )
+        except:
+            # fallback - for some reason best_download doesnt work all the time here
             sh("wget http://eaidata.bmk.sh/data/lambada_test.jsonl -O data/lambada/lambada_test.jsonl")
-#         download_file(
-#             "http://eaidata.bmk.sh/data/lambada_test.jsonl", 
-#             "data/lambada/lambada_test.jsonl", 
-#             "4aa8d02cd17c719165fc8a7887fddd641f43fcafa4b1c806ca8abc31fabdb226"
-#         )
+            sh('echo "4aa8d02cd17c719165fc8a7887fddd641f43fcafa4b1c806ca8abc31fabdb226  data/lambada/lambada_test.jsonl" | sha256sum --check')
 
     def has_training_docs(self):
         return False

lm_eval/tasks/pile.py

@@ -19,8 +19,8 @@ class PilePerplexityTask(PerplexityTask, abc.ABC):
     def download(self):
         # TODO: separate pile val/test out by component so we don't have to scan the entire file once per set
         os.makedirs("data/pile/", exist_ok=True)
-        download_file("https://the-eye.eu/public/AI/pile/val.jsonl.zst", self.VAL_PATH)
-        download_file("https://the-eye.eu/public/AI/pile/test.jsonl.zst", self.TEST_PATH)
+        download_file("https://the-eye.eu/public/AI/pile/val.jsonl.zst", self.VAL_PATH, "264c875d8bbd355d8daa9d032b75fd8fb91606218bb84dd1155b203fcd5fab92")
+        download_file("https://the-eye.eu/public/AI/pile/test.jsonl.zst", self.TEST_PATH, "0bb28c52d0b5596d389bf179ce2d43bf7f7ffae76b0d2d20b180c97f62e0975e")
 
     def validation_docs(self):
         rdr = lm_dataformat.Reader(self.VAL_PATH)

lm_eval/tasks/quac.py

@@ -24,6 +24,7 @@ class QuAC(Task):
 
     def download(self):
         if not os.path.exists('data/quac'):
+            # TODO: convert to use best_download
             sh("""
                 mkdir -p data/quac 
                 wget https://s3.amazonaws.com/my89public/quac/train_v0.2.json -O data/quac/train_v0.2.json

lm_eval/tasks/triviaqa.py

@@ -9,6 +9,7 @@ class TriviaQA(Task):
     VERSION = 0
     def download(self):
         if not os.path.exists('data/triviaqa'):
+            # TODO: convert to best_download
             sh("""
             mkdir -p data/triviaqa
             wget http://nlp.cs.washington.edu/triviaqa/data/triviaqa-unfiltered.tar.gz -O data/triviaqa/trivia_qa-unfiltered.tar.gz