Add gfx90a CI stage for tests (#208)

* Add gfx90a CI stage

* upgrade to ROCm 5.1 and fix formatting

Dockerfile

 FROM ubuntu:18.04
 
-ARG ROCMVERSION=5.0
+ARG ROCMVERSION=5.1
 ARG OSDB_BKC_VERSION
 
 RUN set -xe

Jenkinsfile

@@ -235,6 +235,17 @@ pipeline {
                     }
 
                 }
+                stage("Run Tests: gfx90a")
+                {
+                    agent{ label rocmnode("gfx90a")}
+                    environment{
+                        setup_args = """ -D CMAKE_CXX_FLAGS="--offload-arch=gfx90a -O3 " -DBUILD_DEV=On """
+                    }
+                    steps{
+                        buildHipClangJobAndReboot(setup_args:setup_args, config_targets: "check", no_reboot:true, build_type: 'Release')
+                    }
+
+                }
 
             }
         }

library/src/utility/conv_fwd_util.cpp

@@ -77,8 +77,8 @@ ConvParams::ConvParams(ck::index_t n_dim,
        conv_filter_dilations.size() != num_dim_spatial ||
        input_left_pads.size() != num_dim_spatial || input_right_pads.size() != num_dim_spatial)
     {
-        throw(std::runtime_error(
-            "ConvParams::GetOutputSpatialLengths: "
+        throw(
+            std::runtime_error("ConvParams::GetOutputSpatialLengths: "
                                "parameter size is different from number of declared dimensions!"));
     }
 }
@@ -91,8 +91,8 @@ std::vector<ck::index_t> ConvParams::GetOutputSpatialLengths() const
        conv_filter_dilations.size() != num_dim_spatial ||
        input_left_pads.size() != num_dim_spatial || input_right_pads.size() != num_dim_spatial)
     {
-        throw(std::runtime_error(
-            "ConvParams::GetOutputSpatialLengths: "
+        throw(
+            std::runtime_error("ConvParams::GetOutputSpatialLengths: "
                                "parameter size is different from number of declared dimensions!"));
     }
 
@@ -101,8 +101,7 @@ std::vector<ck::index_t> ConvParams::GetOutputSpatialLengths() const
     {
         // XEff = (X - 1) * conv_dilation_w + 1;
         // Wo = (Wi + in_left_pad_w + in_right_pad_w - XEff) / conv_stride_w + 1;
-        const ck::index_t idx_eff =
-            (filter_spatial_lengths[i] - 1) * conv_filter_dilations[i] + 1;
+        const ck::index_t idx_eff = (filter_spatial_lengths[i] - 1) * conv_filter_dilations[i] + 1;
         out_spatial_len[i] =
             (input_spatial_lengths[i] + input_left_pads[i] + input_right_pads[i] - idx_eff) /
                 conv_filter_strides[i] +