Enforce string-formatting with f-strings (#10980)

* First third

* Styling and fix mistake

* Quality

* All the rest

* Treat %s and %d

* typo

* Missing )

* Apply suggestions from code review
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>

tests/test_trainer_distributed.py

@@ -82,11 +82,8 @@ if __name__ == "__main__":
     training_args = parser.parse_args_into_dataclasses()[0]
 
     logger.warning(
-        "Process rank: %s, device: %s, n_gpu: %s, distributed training: %s",
-        training_args.local_rank,
-        training_args.device,
-        training_args.n_gpu,
-        training_args.local_rank != -1,
+        f"Process rank: {training_args.local_rank}, device: {training_args.device}, n_gpu: {training_args.n_gpu}, "
+        f"distributed training: {training_args.local_rank != -1}"
     )
 
     # Essentially, what we want to verify in the distributed case is that we get all samples back,

tests/test_trainer_tpu.py

@@ -69,10 +69,8 @@ def main():
     training_args = parser.parse_args_into_dataclasses()[0]
 
     logger.warning(
-        "Process rank: %s, device: %s, tpu_num_cores: %s",
-        training_args.local_rank,
-        training_args.device,
-        training_args.tpu_num_cores,
+        f"Process rank: {training_args.local_rank}, device: {training_args.device}, "
+        f"tpu_num_cores: {training_args.tpu_num_cores}",
     )
 
     # Essentially, what we want to verify in the distributed case is

utils/download_glue_data.py

@@ -45,8 +45,8 @@ MRPC_TEST = "https://dl.fbaipublicfiles.com/senteval/senteval_data/msr_paraphras
 
 
 def download_and_extract(task, data_dir):
-    print("Downloading and extracting %s..." % task)
-    data_file = "%s.zip" % task
+    print(f"Downloading and extracting {task}...")
+    data_file = f"{task}.zip"
     urllib.request.urlretrieve(TASK2PATH[task], data_file)
     with zipfile.ZipFile(data_file) as zip_ref:
         zip_ref.extractall(data_dir)

utils/link_tester.py

@@ -91,6 +91,6 @@ if __name__ == "__main__":
     if broken_links:
         print("The following links did not respond:")
         for link in broken_links:
-            print("- {}".format(link))
+            print(f"- {link}")
         sys.exit(1)
     print("All links are ok.")