Unverified Commit 81a73fa6 authored by Yih-Dar's avatar Yih-Dar Committed by GitHub
Browse files

Fix issue introduced in PR #23163 (#23363)



* fix

* fix

---------
Co-authored-by: default avatarydshieh <ydshieh@users.noreply.github.com>
parent 2958b55f
......@@ -234,7 +234,7 @@ class OnnxConfig(ABC):
if is_torch_available():
from transformers.utils import get_torch_version
return get_torch_version() >= self.torch_onnx_minimum_version
return version.parse(get_torch_version()) >= self.torch_onnx_minimum_version
else:
return False
......
......@@ -6,6 +6,7 @@ from unittest import TestCase
from unittest.mock import patch
import pytest
from packaging import version
from parameterized import parameterized
from transformers import AutoConfig, PreTrainedTokenizerBase, is_tf_available, is_torch_available
......@@ -321,7 +322,7 @@ class OnnxExportTestCaseV2(TestCase):
if is_torch_available():
from transformers.utils import get_torch_version
if get_torch_version() < onnx_config.torch_onnx_minimum_version:
if version.parse(get_torch_version()) < onnx_config.torch_onnx_minimum_version:
pytest.skip(
"Skipping due to incompatible PyTorch version. Minimum required is"
f" {onnx_config.torch_onnx_minimum_version}, got: {get_torch_version()}"
......@@ -364,7 +365,7 @@ class OnnxExportTestCaseV2(TestCase):
if is_torch_available():
from transformers.utils import get_torch_version
if get_torch_version() < onnx_config.torch_onnx_minimum_version:
if version.parse(get_torch_version()) < onnx_config.torch_onnx_minimum_version:
pytest.skip(
"Skipping due to incompatible PyTorch version. Minimum required is"
f" {onnx_config.torch_onnx_minimum_version}, got: {get_torch_version()}"
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment