"vscode:/vscode.git/clone" did not exist on "8d68878cc0c2ffcab74ba815c6fd89f0af18e7a4"
Unverified Commit 66f675eb authored by Pavel Iakubovskii's avatar Pavel Iakubovskii Committed by GitHub
Browse files

Fix W&B run name (#30462)

* Remove comparison to output_dir

* Update docs for `run_name`

* Add warning
parent 425e1a04
...@@ -762,9 +762,14 @@ class WandbCallback(TrainerCallback): ...@@ -762,9 +762,14 @@ class WandbCallback(TrainerCallback):
if trial_name is not None: if trial_name is not None:
init_args["name"] = trial_name init_args["name"] = trial_name
init_args["group"] = args.run_name init_args["group"] = args.run_name
else: elif args.run_name is not None:
if not (args.run_name is None or args.run_name == args.output_dir):
init_args["name"] = args.run_name init_args["name"] = args.run_name
if args.run_name == args.output_dir:
self._wandb.termwarn(
"The `run_name` is currently set to the same value as `TrainingArguments.output_dir`. If this was "
"not intended, please specify a different run name by setting the `TrainingArguments.run_name` parameter.",
repeat=False,
)
if self._wandb.run is None: if self._wandb.run is None:
self._wandb.init( self._wandb.init(
......
...@@ -420,9 +420,9 @@ class TrainingArguments: ...@@ -420,9 +420,9 @@ class TrainingArguments:
the past hidden states for their predictions. If this argument is set to a positive int, the `Trainer` will the past hidden states for their predictions. If this argument is set to a positive int, the `Trainer` will
use the corresponding output (usually index 2) as the past state and feed it to the model at the next use the corresponding output (usually index 2) as the past state and feed it to the model at the next
training step under the keyword argument `mems`. training step under the keyword argument `mems`.
run_name (`str`, *optional*): run_name (`str`, *optional*, defaults to `output_dir`):
A descriptor for the run. Typically used for [wandb](https://www.wandb.com/) and A descriptor for the run. Typically used for [wandb](https://www.wandb.com/) and
[mlflow](https://www.mlflow.org/) logging. [mlflow](https://www.mlflow.org/) logging. If not specified, will be the same as `output_dir`.
disable_tqdm (`bool`, *optional*): disable_tqdm (`bool`, *optional*):
Whether or not to disable the tqdm progress bars and table of metrics produced by Whether or not to disable the tqdm progress bars and table of metrics produced by
[`~notebook.NotebookTrainingTracker`] in Jupyter Notebooks. Will default to `True` if the logging level is [`~notebook.NotebookTrainingTracker`] in Jupyter Notebooks. Will default to `True` if the logging level is
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment