".github/vscode:/vscode.git/clone" did not exist on "f8363e49f9030596a5d97f227094e7dac711bfe3"
Unverified Commit 2c887cf8 authored by Sylvain Gugger's avatar Sylvain Gugger Committed by GitHub
Browse files

Do not prepare lr scheduler as it as the right number of steps (#24088)

* Do not prepare lr scheduler as it as the right number of steps

* Trigger CI

* Trigger CI

* Trigger CI

* Add fake comment

* Remove fake comment

* Trigger CI please!
parent 12298cb6
......@@ -1747,9 +1747,7 @@ class Trainer:
# prepare using `accelerator` prepare
if use_accelerator_prepare:
model, self.optimizer, self.lr_scheduler = self.accelerator.prepare(
self.model, self.optimizer, self.lr_scheduler
)
model, self.optimizer = self.accelerator.prepare(self.model, self.optimizer)
if self.is_fsdp_enabled:
self.model = model
......@@ -1996,6 +1994,7 @@ class Trainer:
optimizer_was_run = scale_before <= scale_after
else:
self.optimizer.step()
optimizer_was_run = not self.accelerator.optimizer_step_was_skipped
if optimizer_was_run:
# Delay optimizer scheduling until metrics are generated
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment