Unverified Commit 24092b14 authored by Kyeongpil Kang's avatar Kyeongpil Kang Committed by GitHub
Browse files

Fix typo of variable names for key and query projection layer (#17155)

self.pos_proj and self.pos_q_proj should be changed to self.pos_key_proj and self.pos_query_proj as same as PyTorch implements.
parent 811da2b8
......@@ -604,14 +604,14 @@ class TFDebertaV2DisentangledSelfAttention(tf.keras.layers.Layer):
if not self.share_att_key:
if "c2p" in self.pos_att_type:
self.pos_proj = tf.keras.layers.Dense(
self.pos_key_proj = tf.keras.layers.Dense(
self.all_head_size,
kernel_initializer=get_initializer(config.initializer_range),
name="pos_proj",
use_bias=True,
)
if "p2c" in self.pos_att_type:
self.pos_q_proj = tf.keras.layers.Dense(
self.pos_query_proj = tf.keras.layers.Dense(
self.all_head_size,
kernel_initializer=get_initializer(config.initializer_range),
name="pos_q_proj",
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment