Unverified Commit fc86b18b authored by Glen Liu's avatar Glen Liu Committed by GitHub
Browse files

adjust dynamic vs static outputs comparison in test_lora_update.py (#11884)

parent 0bfa394a
...@@ -28,6 +28,7 @@ from sglang.test.test_utils import ( ...@@ -28,6 +28,7 @@ from sglang.test.test_utils import (
DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH, DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
DEFAULT_URL_FOR_TEST, DEFAULT_URL_FOR_TEST,
CustomTestCase, CustomTestCase,
calculate_rouge_l,
is_in_ci, is_in_ci,
popen_launch_server, popen_launch_server,
) )
...@@ -1278,6 +1279,8 @@ class TestLoRADynamicUpdate(CustomTestCase): ...@@ -1278,6 +1279,8 @@ class TestLoRADynamicUpdate(CustomTestCase):
max_new_tokens=test_case.max_new_tokens, max_new_tokens=test_case.max_new_tokens,
) )
ROUGE_L_TOL = 0.9
print(f"Dynamic output: {dynamic_output}") print(f"Dynamic output: {dynamic_output}")
print(f"Static output: {static_output}") print(f"Static output: {static_output}")
print("=" * 100) print("=" * 100)
...@@ -1295,12 +1298,15 @@ class TestLoRADynamicUpdate(CustomTestCase): ...@@ -1295,12 +1298,15 @@ class TestLoRADynamicUpdate(CustomTestCase):
f"Output length mismatch at batch {i}:\n- Dynamic={len(dynamic)}\n- Static={len(static)}", f"Output length mismatch at batch {i}:\n- Dynamic={len(dynamic)}\n- Static={len(static)}",
) )
for j, (d_out, s_out) in enumerate(zip(dynamic, static), start=1): for j, (d_out, s_out) in enumerate(zip(dynamic, static), start=1):
d_out = d_out.strip() d_out_str = d_out.strip()
s_out = s_out.strip() s_out_str = s_out.strip()
self.assertEqual( rouge_score = calculate_rouge_l([d_out_str], [s_out_str])[0]
d_out,
s_out, self.assertGreaterEqual(
f"Output mismatch at batch {i}, prompt {j}:\n- Dynamic: '{d_out}'\n- Static: '{s_out}'", rouge_score,
ROUGE_L_TOL,
f"ROUGE-L score {rouge_score} of outputs is below tolerance of {ROUGE_L_TOL} "
f"at batch {i}, prompt {j}:\n- Dynamic: '{d_out}'\n- Static: '{s_out}'",
) )
def test_dynamic_lora_update_engine(self): def test_dynamic_lora_update_engine(self):
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment