Unverified Commit fbcbb263 authored by Lianmin Zheng's avatar Lianmin Zheng Committed by GitHub
Browse files

Fix perf regression for set_kv_buffer (#1765)

parent 2fce449b
......@@ -221,17 +221,19 @@ class MHATokenToKVPool(BaseTokenToKVPool):
cache_v: torch.Tensor,
):
layer_id = layer.layer_id
copy_two_array(
loc,
self.k_buffer[layer_id],
cache_k,
self.v_buffer[layer_id],
cache_v,
self.dtype,
self.store_dtype,
)
if cache_k.dtype != self.dtype:
cache_k = cache_k.to(self.dtype)
cache_v = cache_v.to(self.dtype)
if self.store_dtype != self.dtype:
self.k_buffer[layer_id][loc] = cache_k.view(self.store_dtype)
self.v_buffer[layer_id][loc] = cache_v.view(self.store_dtype)
else:
self.k_buffer[layer_id][loc] = cache_k
self.v_buffer[layer_id][loc] = cache_v
# This compiled version is slower in the unit test
# python3 -m unittest test_bench_serving.TestBenchServing.test_offline_throughput_non_stream_small_batch_size
@torch.compile(dynamic=True)
def copy_two_array(loc, dst_1, src_1, dst_2, src_2, dtype, store_dtype):
dst_1[loc] = src_1.to(dtype).view(store_dtype)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment