Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
change
sglang
Commits
855d0ba3
Unverified
Commit
855d0ba3
authored
Dec 27, 2024
by
Lianmin Zheng
Committed by
GitHub
Dec 27, 2024
Browse files
[CI] Fix nightly test and raise better error message (#2626)
Co-authored-by:
Sangbin
<
rkooo567@gmail.com
>
parent
9254a33a
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
16 additions
and
2 deletions
+16
-2
.github/workflows/nightly-test.yml
.github/workflows/nightly-test.yml
+1
-1
python/sglang/srt/server.py
python/sglang/srt/server.py
+10
-1
test/srt/run_suite.py
test/srt/run_suite.py
+5
-0
No files found.
.github/workflows/nightly-test.yml
View file @
855d0ba3
...
@@ -30,5 +30,5 @@ jobs:
...
@@ -30,5 +30,5 @@ jobs:
-
name
:
Run test
-
name
:
Run test
timeout-minutes
:
10
timeout-minutes
:
10
run
:
|
run
:
|
cd test/
lang
cd test/
srt
python3 run_suite.py --suite nightly --timeout-per-file 2400
python3 run_suite.py --suite nightly --timeout-per-file 2400
python/sglang/srt/server.py
View file @
855d0ba3
...
@@ -484,7 +484,16 @@ def launch_engine(
...
@@ -484,7 +484,16 @@ def launch_engine(
# Wait for model to finish loading
# Wait for model to finish loading
scheduler_infos
=
[]
scheduler_infos
=
[]
for
i
in
range
(
len
(
scheduler_pipe_readers
)):
for
i
in
range
(
len
(
scheduler_pipe_readers
)):
try
:
data
=
scheduler_pipe_readers
[
i
].
recv
()
data
=
scheduler_pipe_readers
[
i
].
recv
()
except
EOFError
as
e
:
logger
.
exception
(
e
)
logger
.
error
(
f
"Rank
{
i
}
scheduler is dead. Please check if there are relevant logs."
)
scheduler_procs
[
i
].
join
()
logger
.
error
(
f
"Exit code:
{
scheduler_procs
[
i
].
exitcode
}
"
)
raise
if
data
[
"status"
]
!=
"ready"
:
if
data
[
"status"
]
!=
"ready"
:
raise
RuntimeError
(
raise
RuntimeError
(
...
...
test/srt/run_suite.py
View file @
855d0ba3
...
@@ -44,11 +44,16 @@ suites = {
...
@@ -44,11 +44,16 @@ suites = {
"test_vision_openai_server.py"
,
"test_vision_openai_server.py"
,
"test_session_control.py"
,
"test_session_control.py"
,
],
],
"nightly"
:
[
"test_nightly_gsm8k_eval.py"
,
"test_nightly_human_eval.py"
,
],
"sampling/penaltylib"
:
glob
.
glob
(
"sampling/penaltylib"
:
glob
.
glob
(
"sampling/penaltylib/**/test_*.py"
,
recursive
=
True
"sampling/penaltylib/**/test_*.py"
,
recursive
=
True
),
),
}
}
# Expand suite
for
target_suite_name
,
target_tests
in
suites
.
items
():
for
target_suite_name
,
target_tests
in
suites
.
items
():
for
suite_name
,
tests
in
suites
.
items
():
for
suite_name
,
tests
in
suites
.
items
():
if
suite_name
==
target_suite_name
:
if
suite_name
==
target_suite_name
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment