"src/rpc/vscode:/vscode.git/clone" did not exist on "9d7bf4ea894aa9abcf285163b9586f1ffe5deff3"
Unverified Commit 06008bc2 authored by Lianmin Zheng's avatar Lianmin Zheng Committed by GitHub
Browse files

Fix server launch for jupyter notebook (#186)

parent bb824da4
...@@ -464,7 +464,6 @@ def launch_server(server_args, pipe_finish_writer): ...@@ -464,7 +464,6 @@ def launch_server(server_args, pipe_finish_writer):
assert proc_router.is_alive() and proc_detoken.is_alive() assert proc_router.is_alive() and proc_detoken.is_alive()
def _launch_server(): def _launch_server():
# Launch api server
uvicorn.run( uvicorn.run(
app, app,
host=server_args.host, host=server_args.host,
...@@ -474,9 +473,7 @@ def launch_server(server_args, pipe_finish_writer): ...@@ -474,9 +473,7 @@ def launch_server(server_args, pipe_finish_writer):
loop="uvloop", loop="uvloop",
) )
t = threading.Thread(target=_launch_server) def _wait_and_warmup():
t.start()
url = server_args.url() url = server_args.url()
for _ in range(60): for _ in range(60):
time.sleep(1) time.sleep(1)
...@@ -518,6 +515,13 @@ def launch_server(server_args, pipe_finish_writer): ...@@ -518,6 +515,13 @@ def launch_server(server_args, pipe_finish_writer):
if pipe_finish_writer is not None: if pipe_finish_writer is not None:
pipe_finish_writer.send("init ok") pipe_finish_writer.send("init ok")
t = threading.Thread(target=_wait_and_warmup)
t.start()
try:
_launch_server()
finally:
t.join()
class Runtime: class Runtime:
def __init__( def __init__(
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment