Unverified Commit 00fbd8a4 authored by Stefan He's avatar Stefan He Committed by GitHub
Browse files

Fix typo of flash_cache (#7513)

parent 802815e4
...@@ -2236,8 +2236,8 @@ class Scheduler( ...@@ -2236,8 +2236,8 @@ class Scheduler(
"""In-place update of the weights from disk.""" """In-place update of the weights from disk."""
success, message = self.tp_worker.update_weights_from_disk(recv_req) success, message = self.tp_worker.update_weights_from_disk(recv_req)
if success: if success:
flash_cache_success = self.flush_cache() flush_cache_success = self.flush_cache()
assert flash_cache_success, "Cache flush failed after updating weights" assert flush_cache_success, "Cache flush failed after updating weights"
else: else:
logger.error(message) logger.error(message)
return UpdateWeightFromDiskReqOutput(success, message, 0) return UpdateWeightFromDiskReqOutput(success, message, 0)
...@@ -2254,8 +2254,8 @@ class Scheduler( ...@@ -2254,8 +2254,8 @@ class Scheduler(
"""Update the online model parameter.""" """Update the online model parameter."""
success, message = self.tp_worker.update_weights_from_distributed(recv_req) success, message = self.tp_worker.update_weights_from_distributed(recv_req)
if success: if success:
flash_cache_success = self.flush_cache() flush_cache_success = self.flush_cache()
assert flash_cache_success, "Cache flush failed after updating weights" assert flush_cache_success, "Cache flush failed after updating weights"
else: else:
logger.error(message) logger.error(message)
return UpdateWeightsFromDistributedReqOutput(success, message) return UpdateWeightsFromDistributedReqOutput(success, message)
...@@ -2266,8 +2266,8 @@ class Scheduler( ...@@ -2266,8 +2266,8 @@ class Scheduler(
# TODO extract common code b/t update_weights_from_distributed and update_weights_from_tensor later # TODO extract common code b/t update_weights_from_distributed and update_weights_from_tensor later
if success: if success:
if recv_req.flush_cache: if recv_req.flush_cache:
flash_cache_success = self.flush_cache() flush_cache_success = self.flush_cache()
assert flash_cache_success, "Cache flush failed after updating weights" assert flush_cache_success, "Cache flush failed after updating weights"
else: else:
logger.error(message) logger.error(message)
barrier(group=self.tp_cpu_group) barrier(group=self.tp_cpu_group)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment