Unverified Commit e5ebeeba authored by Harry Mellor's avatar Harry Mellor Committed by GitHub
Browse files

Remove exception for Python 3.8 typing from linter (#22506)


Signed-off-by: default avatarHarry Mellor <19981378+hmellor@users.noreply.github.com>
parent 7be7f382
...@@ -73,8 +73,6 @@ line-length = 80 ...@@ -73,8 +73,6 @@ line-length = 80
"vllm/engine/**/*.py" = ["UP006", "UP035"] "vllm/engine/**/*.py" = ["UP006", "UP035"]
"vllm/executor/**/*.py" = ["UP006", "UP035"] "vllm/executor/**/*.py" = ["UP006", "UP035"]
"vllm/worker/**/*.py" = ["UP006", "UP035"] "vllm/worker/**/*.py" = ["UP006", "UP035"]
# Python 3.8 typing - skip utils for ROCm
"vllm/utils/__init__.py" = ["UP006", "UP035"]
[tool.ruff.lint] [tool.ruff.lint]
select = [ select = [
......
...@@ -47,7 +47,7 @@ from dataclasses import dataclass, field ...@@ -47,7 +47,7 @@ from dataclasses import dataclass, field
from functools import cache, lru_cache, partial, wraps from functools import cache, lru_cache, partial, wraps
from types import MappingProxyType from types import MappingProxyType
from typing import (TYPE_CHECKING, Any, Callable, Generic, Literal, NamedTuple, from typing import (TYPE_CHECKING, Any, Callable, Generic, Literal, NamedTuple,
Optional, TextIO, Tuple, TypeVar, Union, cast, overload) Optional, TextIO, TypeVar, Union, cast, overload)
from urllib.parse import urlparse from urllib.parse import urlparse
from uuid import uuid4 from uuid import uuid4
...@@ -861,7 +861,7 @@ def is_valid_ipv6_address(address: str) -> bool: ...@@ -861,7 +861,7 @@ def is_valid_ipv6_address(address: str) -> bool:
return False return False
def split_host_port(host_port: str) -> Tuple[str, int]: def split_host_port(host_port: str) -> tuple[str, int]:
# ipv6 # ipv6
if host_port.startswith('['): if host_port.startswith('['):
host, port = host_port.rsplit(']', 1) host, port = host_port.rsplit(']', 1)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment