Unverified Commit e497f334 authored by Russell Bryant's avatar Russell Bryant Committed by GitHub
Browse files

[Core] Silence unnecessary deprecation warnings (#12620)



I noticed during testing that I was getting a lot of these deprecation
warnings about `local_lora_path`:

```
DeprecationWarning: The 'lora_local_path' attribute is deprecated
     and will be removed in a future version.
     Please use 'lora_path' instead.
```

The check used for emitting this warning was always True, even when the
parameter was not actually specified. It will always be in
`__struct_fields__`. We should be checking for a non-None value,
instead.
Signed-off-by: default avatarRussell Bryant <rbryant@redhat.com>
Signed-off-by: default avatarRussell Bryant <rbryant@redhat.com>
parent baaa2b24
...@@ -31,7 +31,7 @@ class LoRARequest( ...@@ -31,7 +31,7 @@ class LoRARequest(
base_model_name: Optional[str] = msgspec.field(default=None) base_model_name: Optional[str] = msgspec.field(default=None)
def __post_init__(self): def __post_init__(self):
if 'lora_local_path' in self.__struct_fields__: if self.lora_local_path:
warnings.warn( warnings.warn(
"The 'lora_local_path' attribute is deprecated " "The 'lora_local_path' attribute is deprecated "
"and will be removed in a future version. " "and will be removed in a future version. "
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment