Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
e41e1602
Unverified
Commit
e41e1602
authored
Mar 17, 2025
by
Robert Shaw
Committed by
GitHub
Mar 17, 2025
Browse files
[V1] Guard Against Main Thread Usage (#14972)
Signed-off-by:
rshaw@neuralmagic.com
<
robertgshaw2@gmail.com
>
parent
b89fb2a4
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
0 deletions
+6
-0
vllm/engine/arg_utils.py
vllm/engine/arg_utils.py
+6
-0
No files found.
vllm/engine/arg_utils.py
View file @
e41e1602
...
@@ -3,6 +3,7 @@
...
@@ -3,6 +3,7 @@
import
argparse
import
argparse
import
dataclasses
import
dataclasses
import
json
import
json
import
threading
from
dataclasses
import
dataclass
from
dataclasses
import
dataclass
from
typing
import
(
TYPE_CHECKING
,
Any
,
Dict
,
List
,
Literal
,
Mapping
,
Optional
,
from
typing
import
(
TYPE_CHECKING
,
Any
,
Dict
,
List
,
Literal
,
Mapping
,
Optional
,
Tuple
,
Type
,
Union
,
cast
,
get_args
)
Tuple
,
Type
,
Union
,
cast
,
get_args
)
...
@@ -1576,6 +1577,11 @@ class EngineArgs:
...
@@ -1576,6 +1577,11 @@ class EngineArgs:
#############################################################
#############################################################
# Experimental Features - allow users to opt in.
# Experimental Features - allow users to opt in.
# Signal Handlers requires running in main thread.
if
(
threading
.
current_thread
()
!=
threading
.
main_thread
()
and
_warn_or_fallback
(
"Engine in background thread"
)):
return
False
# LoRA is supported on V1, but off by default for now.
# LoRA is supported on V1, but off by default for now.
if
self
.
enable_lora
and
_warn_or_fallback
(
"LORA"
):
if
self
.
enable_lora
and
_warn_or_fallback
(
"LORA"
):
return
False
return
False
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment