Unverified Commit e2d8c27f authored by Nick Hill's avatar Nick Hill Committed by GitHub
Browse files

[BugFix] Fix pipeline parallel (#24621)


Signed-off-by: default avatarNick Hill <nhill@redhat.com>
parent 29799dda
...@@ -71,6 +71,10 @@ class UniProcExecutor(ExecutorBase): ...@@ -71,6 +71,10 @@ class UniProcExecutor(ExecutorBase):
self.shutdown() self.shutdown()
return return
def shutdown(self) -> None:
if worker := self.driver_worker:
worker.shutdown()
UniProcExecutorAsync = UniProcExecutor UniProcExecutorAsync = UniProcExecutor
......
...@@ -2070,7 +2070,6 @@ class GPUModelRunner(LoRAModelRunnerMixin, KVConnectorModelRunnerMixin): ...@@ -2070,7 +2070,6 @@ class GPUModelRunner(LoRAModelRunnerMixin, KVConnectorModelRunnerMixin):
sampler_output = self._sample(logits, spec_decode_metadata) sampler_output = self._sample(logits, spec_decode_metadata)
with record_function_or_nullcontext("Bookkeep"): with record_function_or_nullcontext("Bookkeep"):
assert isinstance(hidden_states, torch.Tensor)
( (
num_nans_in_logits, num_nans_in_logits,
logprobs_lists, logprobs_lists,
......
...@@ -45,7 +45,8 @@ class KVConnectorModelRunnerMixin: ...@@ -45,7 +45,8 @@ class KVConnectorModelRunnerMixin:
@staticmethod @staticmethod
def ensure_kv_transfer_shutdown() -> None: def ensure_kv_transfer_shutdown() -> None:
if has_kv_transfer_group(): # has_kv_transfer_group can be None during interpreter shutdown.
if has_kv_transfer_group and has_kv_transfer_group():
ensure_kv_transfer_shutdown() ensure_kv_transfer_shutdown()
@staticmethod @staticmethod
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment