Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
d02d1043
Unverified
Commit
d02d1043
authored
Dec 11, 2025
by
Ning Xie
Committed by
GitHub
Dec 10, 2025
Browse files
fix: enhance human_readable_int function (#30337)
Signed-off-by:
Andy Xie
<
andy.xning@gmail.com
>
parent
979f50ef
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
4 deletions
+21
-4
tests/engine/test_arg_utils.py
tests/engine/test_arg_utils.py
+18
-4
vllm/engine/arg_utils.py
vllm/engine/arg_utils.py
+3
-0
No files found.
tests/engine/test_arg_utils.py
View file @
d02d1043
...
@@ -350,21 +350,35 @@ def test_human_readable_model_len():
...
@@ -350,21 +350,35 @@ def test_human_readable_model_len():
assert
args
.
max_model_len
==
1_000_000
assert
args
.
max_model_len
==
1_000_000
args
=
parser
.
parse_args
([
"--max-model-len"
,
"10k"
])
args
=
parser
.
parse_args
([
"--max-model-len"
,
"10k"
])
assert
args
.
max_model_len
==
10_000
assert
args
.
max_model_len
==
10_000
args
=
parser
.
parse_args
([
"--max-model-len"
,
"2g"
])
assert
args
.
max_model_len
==
2_000_000_000
args
=
parser
.
parse_args
([
"--max-model-len"
,
"2t"
])
assert
args
.
max_model_len
==
2_000_000_000_000
# Capital
# Capital
args
=
parser
.
parse_args
([
"--max-model-len"
,
"3K"
])
args
=
parser
.
parse_args
([
"--max-model-len"
,
"3K"
])
assert
args
.
max_model_len
==
10
24
*
3
assert
args
.
max_model_len
==
2
**
10
*
3
args
=
parser
.
parse_args
([
"--max-model-len"
,
"10M"
])
args
=
parser
.
parse_args
([
"--max-model-len"
,
"10M"
])
assert
args
.
max_model_len
==
2
**
20
*
10
assert
args
.
max_model_len
==
2
**
20
*
10
args
=
parser
.
parse_args
([
"--max-model-len"
,
"4G"
])
assert
args
.
max_model_len
==
2
**
30
*
4
args
=
parser
.
parse_args
([
"--max-model-len"
,
"4T"
])
assert
args
.
max_model_len
==
2
**
40
*
4
# Decimal values
# Decimal values
args
=
parser
.
parse_args
([
"--max-model-len"
,
"10.2k"
])
args
=
parser
.
parse_args
([
"--max-model-len"
,
"10.2k"
])
assert
args
.
max_model_len
==
10200
assert
args
.
max_model_len
==
10200
# ..truncated to the nearest int
# ..truncated to the nearest int
args
=
parser
.
parse_args
([
"--max-model-len"
,
"10.212345k"
])
args
=
parser
.
parse_args
([
"--max-model-len"
,
"10.212345
1234567
k"
])
assert
args
.
max_model_len
==
10212
assert
args
.
max_model_len
==
10212
args
=
parser
.
parse_args
([
"--max-model-len"
,
"10.2123451234567m"
])
assert
args
.
max_model_len
==
10212345
args
=
parser
.
parse_args
([
"--max-model-len"
,
"10.2123451234567g"
])
assert
args
.
max_model_len
==
10212345123
args
=
parser
.
parse_args
([
"--max-model-len"
,
"10.2123451234567t"
])
assert
args
.
max_model_len
==
10212345123456
# Invalid (do not allow decimals with binary multipliers)
# Invalid (do not allow decimals with binary multipliers)
for
invalid
in
[
"1a"
,
"pwd"
,
"10.24"
,
"1.23M"
]:
for
invalid
in
[
"1a"
,
"pwd"
,
"10.24"
,
"1.23M"
,
"1.22T"
]:
with
pytest
.
raises
(
ArgumentError
):
with
pytest
.
raises
(
ArgumentError
):
args
=
parser
.
parse_args
([
"--max-model-len"
,
invalid
])
parser
.
parse_args
([
"--max-model-len"
,
invalid
])
vllm/engine/arg_utils.py
View file @
d02d1043
...
@@ -1783,6 +1783,7 @@ class EngineArgs:
...
@@ -1783,6 +1783,7 @@ class EngineArgs:
except
Exception
:
except
Exception
:
# This is only used to set default_max_num_batched_tokens
# This is only used to set default_max_num_batched_tokens
device_memory
=
0
device_memory
=
0
device_name
=
""
# NOTE(Kuntai): Setting large `max_num_batched_tokens` for A100 reduces
# NOTE(Kuntai): Setting large `max_num_batched_tokens` for A100 reduces
# throughput, see PR #17885 for more details.
# throughput, see PR #17885 for more details.
...
@@ -2042,11 +2043,13 @@ def human_readable_int(value):
...
@@ -2042,11 +2043,13 @@ def human_readable_int(value):
"k"
:
10
**
3
,
"k"
:
10
**
3
,
"m"
:
10
**
6
,
"m"
:
10
**
6
,
"g"
:
10
**
9
,
"g"
:
10
**
9
,
"t"
:
10
**
12
,
}
}
binary_multiplier
=
{
binary_multiplier
=
{
"K"
:
2
**
10
,
"K"
:
2
**
10
,
"M"
:
2
**
20
,
"M"
:
2
**
20
,
"G"
:
2
**
30
,
"G"
:
2
**
30
,
"T"
:
2
**
40
,
}
}
number
,
suffix
=
match
.
groups
()
number
,
suffix
=
match
.
groups
()
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment