"vscode:/vscode.git/clone" did not exist on "f58454968fe1c5ddf84199b341a6ed5c99f0c0cc"
Unverified Commit c9acbf11 authored by Jee Jee Li's avatar Jee Jee Li Committed by GitHub
Browse files

[Misc] Remove the chunked prefill warning for LoRA (#16925)


Signed-off-by: default avatarJee Jee Li <pandaleefree@gmail.com>
parent 5b794cae
...@@ -2686,13 +2686,6 @@ class LoRAConfig: ...@@ -2686,13 +2686,6 @@ class LoRAConfig:
elif isinstance(self.lora_dtype, str): elif isinstance(self.lora_dtype, str):
self.lora_dtype = getattr(torch, self.lora_dtype) self.lora_dtype = getattr(torch, self.lora_dtype)
def verify_with_scheduler_config(self, scheduler_config: SchedulerConfig):
# Reminder: Please update docs/source/features/compatibility_matrix.md
# If the feature combo become valid
if scheduler_config.chunked_prefill_enabled:
logger.warning("LoRA with chunked prefill is still experimental "
"and may be unstable.")
def verify_lora_support(self): def verify_lora_support(self):
if self.long_lora_scaling_factors is not None and envs.VLLM_USE_V1: if self.long_lora_scaling_factors is not None and envs.VLLM_USE_V1:
raise ValueError( raise ValueError(
...@@ -3820,8 +3813,6 @@ class VllmConfig: ...@@ -3820,8 +3813,6 @@ class VllmConfig:
if self.lora_config: if self.lora_config:
self.lora_config.verify_with_cache_config(self.cache_config) self.lora_config.verify_with_cache_config(self.cache_config)
self.lora_config.verify_with_model_config(self.model_config) self.lora_config.verify_with_model_config(self.model_config)
self.lora_config.verify_with_scheduler_config(
self.scheduler_config)
self.lora_config.verify_lora_support() self.lora_config.verify_lora_support()
if self.prompt_adapter_config: if self.prompt_adapter_config:
self.prompt_adapter_config.verify_with_model_config( self.prompt_adapter_config.verify_with_model_config(
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment