"vllm/vscode:/vscode.git/clone" did not exist on "d4db9f53c8a50a2b0788cf1e03b5b91f20de4313"
Unverified Commit c012a8c4 authored by Jeffrey Wang's avatar Jeffrey Wang Committed by GitHub
Browse files

Don't fire ray compatibility webhook when PR or branch is not provided (#36088)


Signed-off-by: default avatarJeffrey Wang <jeffreywang@anyscale.com>
parent ebed80a7
...@@ -166,8 +166,15 @@ See [issue #33599](https://github.com/vllm-project/vllm/issues/33599) for contex ...@@ -166,8 +166,15 @@ See [issue #33599](https://github.com/vllm-project/vllm/issues/33599) for contex
EOF EOF
fi fi
# Notify Slack if webhook is configured. # Notify Slack if webhook is configured and PR/branch are valid.
if [ -n "$RAY_COMPAT_SLACK_WEBHOOK_URL" ]; then if [ -n "$RAY_COMPAT_SLACK_WEBHOOK_URL" ]; then
PR="${BUILDKITE_PULL_REQUEST:-}"
BRANCH="${BUILDKITE_BRANCH:-}"
# Skip notification if PR is invalid or branch is empty
if [[ "$PR" = "false" || -z "$PR" || -z "$BRANCH" ]]; then
echo ">>> Skipping Slack notification (invalid PR or empty branch: PR=$PR, branch=$BRANCH)"
else
echo ">>> Sending Slack notification" echo ">>> Sending Slack notification"
# Single quotes are intentional: the f-string expressions are Python, not shell. # Single quotes are intentional: the f-string expressions are Python, not shell.
# shellcheck disable=SC2016 # shellcheck disable=SC2016
...@@ -198,6 +205,7 @@ print(json.dumps(data)) ...@@ -198,6 +205,7 @@ print(json.dumps(data))
-H 'Content-type: application/json' \ -H 'Content-type: application/json' \
-d "$PAYLOAD") -d "$PAYLOAD")
echo " Slack webhook response: $HTTP_CODE" echo " Slack webhook response: $HTTP_CODE"
fi
else else
echo ">>> Skipping Slack notification (RAY_COMPAT_SLACK_WEBHOOK_URL not set)" echo ">>> Skipping Slack notification (RAY_COMPAT_SLACK_WEBHOOK_URL not set)"
fi fi
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment