Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
becbe248
Unverified
Commit
becbe248
authored
Feb 13, 2026
by
Isotr0py
Committed by
GitHub
Feb 12, 2026
Browse files
[Bugfix] Remove broken raw url GGUF model loading support (#34433)
Signed-off-by:
Isotr0py
<
mozf@mail2.sysu.edu.cn
>
parent
679ca5d8
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
25 deletions
+1
-25
tests/models/test_gguf_download.py
tests/models/test_gguf_download.py
+0
-19
vllm/model_executor/model_loader/gguf_loader.py
vllm/model_executor/model_loader/gguf_loader.py
+1
-6
No files found.
tests/models/test_gguf_download.py
View file @
becbe248
...
...
@@ -113,25 +113,6 @@ class TestGGUFModelLoader:
assert
result
==
"/path/to/model.gguf"
mock_isfile
.
assert_called_once_with
(
"/path/to/model.gguf"
)
@
patch
(
"vllm.model_executor.model_loader.gguf_loader.hf_hub_download"
)
@
patch
(
"os.path.isfile"
,
return_value
=
False
)
def
test_prepare_weights_https_url
(
self
,
mock_isfile
,
mock_hf_download
):
"""Test _prepare_weights with HTTPS URL."""
load_config
=
LoadConfig
(
load_format
=
"gguf"
)
loader
=
GGUFModelLoader
(
load_config
)
mock_hf_download
.
return_value
=
"/downloaded/model.gguf"
# Create a simple mock ModelConfig with only the model attribute
model_config
=
MagicMock
()
model_config
.
model
=
"https://huggingface.co/model.gguf"
result
=
loader
.
_prepare_weights
(
model_config
)
assert
result
==
"/downloaded/model.gguf"
mock_hf_download
.
assert_called_once_with
(
url
=
"https://huggingface.co/model.gguf"
)
@
patch
(
"vllm.model_executor.model_loader.gguf_loader.hf_hub_download"
)
@
patch
(
"os.path.isfile"
,
return_value
=
False
)
def
test_prepare_weights_repo_filename
(
self
,
mock_isfile
,
mock_hf_download
):
...
...
vllm/model_executor/model_loader/gguf_loader.py
View file @
becbe248
...
...
@@ -49,11 +49,6 @@ class GGUFModelLoader(BaseModelLoader):
model_name_or_path
=
model_config
.
model
if
os
.
path
.
isfile
(
model_name_or_path
):
return
model_name_or_path
# for raw HTTPS link
if
model_name_or_path
.
startswith
(
(
"http://"
,
"https://"
)
)
and
model_name_or_path
.
endswith
(
".gguf"
):
return
hf_hub_download
(
url
=
model_name_or_path
)
# repo id/filename.gguf
if
"/"
in
model_name_or_path
and
model_name_or_path
.
endswith
(
".gguf"
):
repo_id
,
filename
=
model_name_or_path
.
rsplit
(
"/"
,
1
)
...
...
@@ -71,7 +66,7 @@ class GGUFModelLoader(BaseModelLoader):
raise
ValueError
(
f
"Unrecognised GGUF reference:
{
model_name_or_path
}
"
"(expected local file,
raw URL,
<repo_id>/<filename>.gguf, "
"(expected local file, <repo_id>/<filename>.gguf, "
"or <repo_id>:<quant_type>)"
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment