Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
bd828722
Unverified
Commit
bd828722
authored
Jan 09, 2025
by
youkaichao
Committed by
GitHub
Jan 09, 2025
Browse files
[ci]try to fix flaky multi-step tests (#11894)
Signed-off-by:
youkaichao
<
youkaichao@gmail.com
>
parent
405eb8e3
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
4 deletions
+8
-4
tests/multi_step/test_correctness_async_llm.py
tests/multi_step/test_correctness_async_llm.py
+1
-2
tests/utils.py
tests/utils.py
+7
-2
No files found.
tests/multi_step/test_correctness_async_llm.py
View file @
bd828722
...
...
@@ -16,7 +16,6 @@ NUM_SCHEDULER_STEPS = [8] # Multi-step decoding steps
NUM_PROMPTS
=
[
10
]
DEFAULT_SERVER_ARGS
:
List
[
str
]
=
[
"--disable-log-requests"
,
"--worker-use-ray"
,
"--gpu-memory-utilization"
,
"0.85"
,
...
...
@@ -110,7 +109,7 @@ async def test_multi_step(
# Spin up client/server & issue completion API requests.
# Default `max_wait_seconds` is 240 but was empirically
# was raised
3
x to
72
0 *just for this test* due to
# was raised
5
x to
120
0 *just for this test* due to
# observed timeouts in GHA CI
ref_completions
=
await
completions_with_server_args
(
prompts
,
...
...
tests/utils.py
View file @
bd828722
...
...
@@ -157,13 +157,19 @@ class RemoteOpenAIServer:
def
url_for
(
self
,
*
parts
:
str
)
->
str
:
return
self
.
url_root
+
"/"
+
"/"
.
join
(
parts
)
def
get_client
(
self
):
def
get_client
(
self
,
**
kwargs
):
if
"timeout"
not
in
kwargs
:
kwargs
[
"timeout"
]
=
600
return
openai
.
OpenAI
(
base_url
=
self
.
url_for
(
"v1"
),
api_key
=
self
.
DUMMY_API_KEY
,
max_retries
=
0
,
**
kwargs
,
)
def
get_async_client
(
self
,
**
kwargs
):
if
"timeout"
not
in
kwargs
:
kwargs
[
"timeout"
]
=
600
return
openai
.
AsyncOpenAI
(
base_url
=
self
.
url_for
(
"v1"
),
api_key
=
self
.
DUMMY_API_KEY
,
max_retries
=
0
,
...
...
@@ -780,7 +786,6 @@ async def completions_with_server_args(
assert
len
(
max_tokens
)
==
len
(
prompts
)
outputs
=
None
max_wait_seconds
=
240
*
3
# 240 is default
with
RemoteOpenAIServer
(
model_name
,
server_cli_args
,
max_wait_seconds
=
max_wait_seconds
)
as
server
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment