Unverified Commit bb7991aa authored by Roger Wang's avatar Roger Wang Committed by GitHub
Browse files

[V1] Add missing tokenizer options for `Detokenizer` (#10288)


Signed-off-by: default avatarRoger Wang <ywang@roblox.com>
parent d909acf9
...@@ -192,10 +192,17 @@ class IncrementalDetokenizer: ...@@ -192,10 +192,17 @@ class IncrementalDetokenizer:
class Detokenizer: class Detokenizer:
def __init__(self, tokenizer_name: str): def __init__(self,
tokenizer_name: str,
tokenizer_mode: str = "auto",
trust_remote_code: bool = False,
revision: Optional[str] = None):
# TODO: once we support LoRA, we should should pass the tokenizer # TODO: once we support LoRA, we should should pass the tokenizer
# here. We currently have two copies (this + in the LLMEngine). # here. We currently have two copies (this + in the LLMEngine).
self.tokenizer = get_tokenizer(tokenizer_name) self.tokenizer = get_tokenizer(tokenizer_name=tokenizer_name,
tokenizer_mode=tokenizer_mode,
trust_remote_code=trust_remote_code,
revision=revision)
# Request id -> IncrementalDetokenizer # Request id -> IncrementalDetokenizer
self.request_states: Dict[str, IncrementalDetokenizer] = {} self.request_states: Dict[str, IncrementalDetokenizer] = {}
......
...@@ -53,7 +53,12 @@ class LLMEngine: ...@@ -53,7 +53,12 @@ class LLMEngine:
input_registry) input_registry)
# Detokenizer (converts EngineCoreOutputs --> RequestOutput) # Detokenizer (converts EngineCoreOutputs --> RequestOutput)
self.detokenizer = Detokenizer(vllm_config.model_config.tokenizer) self.detokenizer = Detokenizer(
tokenizer_name=vllm_config.model_config.tokenizer,
tokenizer_mode=vllm_config.model_config.tokenizer_mode,
trust_remote_code=vllm_config.model_config.trust_remote_code,
revision=vllm_config.model_config.tokenizer_revision,
)
# EngineCore (gets EngineCoreRequests and gives EngineCoreOutputs) # EngineCore (gets EngineCoreRequests and gives EngineCoreOutputs)
self.engine_core = EngineCoreClient.make_client( self.engine_core = EngineCoreClient.make_client(
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment