Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
b2f195c4
Unverified
Commit
b2f195c4
authored
Apr 22, 2025
by
Nick Hill
Committed by
GitHub
Apr 23, 2025
Browse files
[V1] Avoid socket errors during shutdown when requests are in in-flight (#16807)
Signed-off-by:
Nick Hill
<
nhill@redhat.com
>
parent
047797ef
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
5 deletions
+7
-5
vllm/v1/engine/core.py
vllm/v1/engine/core.py
+1
-1
vllm/v1/engine/core_client.py
vllm/v1/engine/core_client.py
+6
-4
No files found.
vllm/v1/engine/core.py
View file @
b2f195c4
...
...
@@ -384,7 +384,7 @@ class EngineCoreProc(EngineCore):
except
SystemExit
:
logger
.
debug
(
"EngineCore exiting."
)
raise
except
Exception
as
e
:
if
engine_core
is
None
:
logger
.
exception
(
"EngineCore failed to start."
)
...
...
vllm/v1/engine/core_client.py
View file @
b2f195c4
...
...
@@ -312,6 +312,7 @@ class BackgroundResources:
def
__call__
(
self
):
"""Clean up background resources."""
self
.
engine_dead
=
True
for
core_engine
in
self
.
core_engines
:
core_engine
.
close
()
...
...
@@ -564,7 +565,7 @@ class SyncMPClient(MPClient):
self
.
_send_input
(
EngineCoreRequestType
.
ADD
,
request
)
def
abort_requests
(
self
,
request_ids
:
list
[
str
])
->
None
:
if
len
(
request_ids
)
>
0
:
if
request_ids
and
not
self
.
resources
.
engine_dead
:
self
.
_send_input
(
EngineCoreRequestType
.
ABORT
,
request_ids
)
def
profile
(
self
,
is_start
:
bool
=
True
)
->
None
:
...
...
@@ -735,7 +736,7 @@ class AsyncMPClient(MPClient):
self
.
_ensure_output_queue_task
()
async
def
abort_requests_async
(
self
,
request_ids
:
list
[
str
])
->
None
:
if
len
(
request_ids
)
>
0
:
if
request_ids
and
not
self
.
resources
.
engine_dead
:
await
self
.
_send_input
(
EngineCoreRequestType
.
ABORT
,
request_ids
)
async
def
profile_async
(
self
,
is_start
:
bool
=
True
)
->
None
:
...
...
@@ -902,5 +903,6 @@ class DPAsyncMPClient(AsyncMPClient):
async
def
_abort_requests
(
self
,
request_ids
:
list
[
str
],
engine
:
CoreEngine
)
->
None
:
if
not
self
.
resources
.
engine_dead
:
await
self
.
_send_input
(
EngineCoreRequestType
.
ABORT
,
request_ids
,
engine
)
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment