Unverified Commit ad2d7880 authored by Ekagra Ranjan's avatar Ekagra Ranjan Committed by GitHub
Browse files

[Bug][Benchmark] Fix duplicate req in oversampling (#26140)


Signed-off-by: default avatarEkagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
Co-authored-by: default avatarRoger Wang <hey@rogerw.io>
parent 36ce76c6
...@@ -235,16 +235,22 @@ class BenchmarkDataset(ABC): ...@@ -235,16 +235,22 @@ class BenchmarkDataset(ABC):
if len(requests) < num_requests: if len(requests) < num_requests:
random.seed(self.random_seed) random.seed(self.random_seed)
additional = deepcopy( needed = num_requests - len(requests)
random.choices(requests, k=num_requests - len(requests)) additional = []
) for i in range(needed):
for i in range(len(additional)): req = deepcopy(random.choice(requests))
req = additional[i]
req.request_id = request_id_prefix + str(len(requests) + i) req.request_id = request_id_prefix + str(len(requests) + i)
additional.append(req)
requests.extend(additional) requests.extend(additional)
logger.info("Oversampled requests to reach %d total samples.", logger.info("Oversampled requests to reach %d total samples.",
num_requests) num_requests)
ids = [req.request_id for req in requests]
if len(ids) != len(set(ids)):
raise ValueError("Duplicate request_id found in the sampled "
"requests. Please ensure that each request_id "
"is unique.")
# ----------------------------------------------------------------------------- # -----------------------------------------------------------------------------
# Utility Functions and Global Caches # Utility Functions and Global Caches
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment