Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
a944f8ed
Unverified
Commit
a944f8ed
authored
May 08, 2025
by
Jee Jee Li
Committed by
GitHub
May 08, 2025
Browse files
[Misc] Delete LoRA-related redundancy code (#17841)
Signed-off-by:
Jee Jee Li
<
pandaleefree@gmail.com
>
parent
015815fe
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
3 additions
and
17 deletions
+3
-17
vllm/lora/models.py
vllm/lora/models.py
+1
-1
vllm/model_executor/models/grok1.py
vllm/model_executor/models/grok1.py
+1
-3
vllm/model_executor/models/nemotron_nas.py
vllm/model_executor/models/nemotron_nas.py
+0
-8
vllm/model_executor/models/phi4mm.py
vllm/model_executor/models/phi4mm.py
+1
-5
No files found.
vllm/lora/models.py
View file @
a944f8ed
...
...
@@ -344,7 +344,7 @@ class LoRAModelManager(AdapterModelManager):
self
.
supported_lora_modules
=
get_supported_lora_modules
(
self
.
model
)
assert
self
.
supported_lora_modules
,
"No supported LoRA modules found in"
f
"
{
self
.
model
.
__class__
.
__name__
}
."
f
"
{
self
.
model
.
__class__
.
__name__
}
."
if
lora_config
.
long_lora_scaling_factors
:
# We need to replace rotary emb layer to do batch computation
# for long lora.
...
...
vllm/model_executor/models/grok1.py
View file @
a944f8ed
...
...
@@ -504,9 +504,7 @@ class Grok1ForCausalLM(nn.Module, SupportsLoRA, SupportsPP):
self
.
unpadded_vocab_size
,
config
.
hidden_size
,
org_num_embeddings
=
config
.
vocab_size
,
padding_size
=
DEFAULT_VOCAB_PADDING_SIZE
# We need bigger padding if using lora for kernel compatibility
if
not
lora_config
else
lora_config
.
lora_vocab_padding_size
,
padding_size
=
DEFAULT_VOCAB_PADDING_SIZE
,
quant_config
=
quant_config
,
prefix
=
maybe_prefix
(
prefix
,
"lm_head"
),
)
...
...
vllm/model_executor/models/nemotron_nas.py
View file @
a944f8ed
...
...
@@ -334,14 +334,6 @@ class DeciLMForCausalLM(nn.Module, SupportsLoRA, SupportsPP, HasNoOps):
}
# LoRA specific attributes
supported_lora_modules
=
[
"qkv_proj"
,
"o_proj"
,
"gate_up_proj"
,
"down_proj"
,
"embed_tokens"
,
"lm_head"
,
]
embedding_modules
=
{
"embed_tokens"
:
"input_embeddings"
,
"lm_head"
:
"output_embeddings"
,
...
...
vllm/model_executor/models/phi4mm.py
View file @
a944f8ed
...
...
@@ -955,11 +955,7 @@ class Phi4MMForCausalLM(nn.Module, SupportsLoRA, SupportsMultiModal):
self
.
unpadded_vocab_size
,
config
.
hidden_size
,
org_num_embeddings
=
config
.
vocab_size
,
padding_size
=
(
DEFAULT_VOCAB_PADDING_SIZE
# We need bigger padding if using lora for kernel
# compatibility
if
not
lora_config
else
lora_config
.
lora_vocab_padding_size
),
padding_size
=
DEFAULT_VOCAB_PADDING_SIZE
,
quant_config
=
quant_config
,
)
if
config
.
tie_word_embeddings
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment