Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
a4cf2561
Unverified
Commit
a4cf2561
authored
Dec 03, 2024
by
Jee Jee Li
Committed by
GitHub
Dec 03, 2024
Browse files
[Bugfix] Fix QKVParallelLinearWithShardedLora bias bug (#10844)
Signed-off-by:
Jee Jee Li
<
pandaleefree@gmail.com
>
parent
d746268e
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
9 deletions
+1
-9
.buildkite/test-pipeline.yaml
.buildkite/test-pipeline.yaml
+0
-1
vllm/lora/fully_sharded_layers.py
vllm/lora/fully_sharded_layers.py
+1
-8
No files found.
.buildkite/test-pipeline.yaml
View file @
a4cf2561
...
@@ -481,7 +481,6 @@ steps:
...
@@ -481,7 +481,6 @@ steps:
-
label
:
LoRA TP Test (Distributed)
-
label
:
LoRA TP Test (Distributed)
num_gpus
:
4
num_gpus
:
4
soft_fail
:
true
source_file_dependencies
:
source_file_dependencies
:
-
vllm/lora
-
vllm/lora
-
tests/lora
-
tests/lora
...
...
vllm/lora/fully_sharded_layers.py
View file @
a4cf2561
...
@@ -77,13 +77,6 @@ class ColumnParallelLinearWithShardedLoRA(ColumnParallelLinearWithLoRA):
...
@@ -77,13 +77,6 @@ class ColumnParallelLinearWithShardedLoRA(ColumnParallelLinearWithLoRA):
add_input
=
True
)
add_input
=
True
)
# now have column partitioned output
# now have column partitioned output
if
self
.
bias_stacked
is
not
None
:
self
.
bias_stacked
=
self
.
bias_stacked
.
view
(
-
1
,
self
.
bias_stacked
.
shape
[
-
1
])
self
.
bias_stacked
=
self
.
bias_stacked
[
self
.
punica_wrapper
.
token_lora_indices
]
output
+=
self
.
bias_stacked
output
=
output
.
view
(
*
out_orig_shape
)
output
=
output
.
view
(
*
out_orig_shape
)
return
output
return
output
...
@@ -222,7 +215,7 @@ class QKVParallelLinearWithShardedLora(QKVParallelLinearWithLora):
...
@@ -222,7 +215,7 @@ class QKVParallelLinearWithShardedLora(QKVParallelLinearWithLora):
self
.
punica_wrapper
.
add_expand
(
output
,
self
.
punica_wrapper
.
add_expand
(
output
,
buffer
,
buffer
,
self
.
lora_b_stacked
,
self
.
lora_b_stacked
,
self
.
bias_
all
,
self
.
bias_
stacked
,
add_input
=
True
)
add_input
=
True
)
# now have column partitioned output
# now have column partitioned output
output
=
output
.
view
(
*
out_orig_shape
)
output
=
output
.
view
(
*
out_orig_shape
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment