Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
a32c8669
Unverified
Commit
a32c8669
authored
Mar 05, 2025
by
Nick Hill
Committed by
GitHub
Mar 05, 2025
Browse files
[V1][Minor] Remove obsolete FIXME comment (#14304)
Signed-off-by:
Nick Hill
<
nhill@redhat.com
>
parent
ca2ca8de
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
0 additions
and
5 deletions
+0
-5
vllm/v1/worker/gpu_input_batch.py
vllm/v1/worker/gpu_input_batch.py
+0
-5
No files found.
vllm/v1/worker/gpu_input_batch.py
View file @
a32c8669
...
...
@@ -298,11 +298,6 @@ class InputBatch:
if
sampling_params
.
logit_bias
is
not
None
:
self
.
logit_bias
[
req_index
]
=
sampling_params
.
logit_bias
# FIXME: this implementation is incorrect. We create this mask
# then apply -inf to these specific tokens, which means we never
# select the allowed tokens! We cannot do the reverse, since
# this will impact the requests that do not have allowed_token_ids.
# This feature is currently disabled on V1 (we reject in Processor).
if
sampling_params
.
allowed_token_ids
:
self
.
has_allowed_token_ids
.
add
(
req_id
)
if
self
.
allowed_token_ids_mask_cpu_tensor
is
None
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment