Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
95aca283
Unverified
Commit
95aca283
authored
Apr 16, 2025
by
Divakar Verma
Committed by
GitHub
Apr 16, 2025
Browse files
[rocm][V0] fix selection logic for custom PA in V0 (#16426)
Signed-off-by:
Divakar Verma
<
divakar.verma@amd.com
>
parent
2b05b8ce
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
1 deletion
+4
-1
vllm/platforms/rocm.py
vllm/platforms/rocm.py
+4
-1
No files found.
vllm/platforms/rocm.py
View file @
95aca283
...
...
@@ -109,8 +109,11 @@ def use_rocm_custom_paged_attention(qtype: torch.dtype, head_size: int,
ON_MI250_MI300
=
any
(
arch
in
GPU_ARCH
for
arch
in
[
"gfx90a"
,
"gfx942"
])
# rocm custom page attention not support on navi (gfx1*)
# custom paged attn always supported on V0. On V1, requires sliding window
# disabled due to observed numerical discrepancy.
return
(
ON_MI250_MI300
and
not
ON_NAVI
and
(
sliding_window
==
0
or
sliding_window
==
(
-
1
,
-
1
))
and
(
not
envs
.
VLLM_USE_V1
or
sliding_window
==
0
or
sliding_window
==
(
-
1
,
-
1
))
and
(
qtype
==
torch
.
half
or
qtype
==
torch
.
bfloat16
)
and
(
head_size
==
64
or
head_size
==
128
)
and
(
block_size
==
16
or
block_size
==
32
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment