Unverified Commit 890ca360 authored by Kevin H. Luu's avatar Kevin H. Luu Committed by GitHub
Browse files

Revert "[Bugfix] Use host argument to bind to interface (#9798)" (#9852)

parent abbfb613
...@@ -544,7 +544,7 @@ async def run_server(args, **uvicorn_kwargs) -> None: ...@@ -544,7 +544,7 @@ async def run_server(args, **uvicorn_kwargs) -> None:
# This avoids race conditions with ray. # This avoids race conditions with ray.
# see https://github.com/vllm-project/vllm/issues/8204 # see https://github.com/vllm-project/vllm/issues/8204
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
sock.bind((args.host, args.port)) sock.bind(("", args.port))
def signal_handler(*_) -> None: def signal_handler(*_) -> None:
# Interrupt server on sigterm while initializing # Interrupt server on sigterm while initializing
......
...@@ -77,7 +77,7 @@ class PromptAdapterParserAction(argparse.Action): ...@@ -77,7 +77,7 @@ class PromptAdapterParserAction(argparse.Action):
def make_arg_parser(parser: FlexibleArgumentParser) -> FlexibleArgumentParser: def make_arg_parser(parser: FlexibleArgumentParser) -> FlexibleArgumentParser:
parser.add_argument("--host", parser.add_argument("--host",
type=nullable_str, type=nullable_str,
default="0.0.0.0", default=None,
help="host name") help="host name")
parser.add_argument("--port", type=int, default=8000, help="port number") parser.add_argument("--port", type=int, default=8000, help="port number")
parser.add_argument( parser.add_argument(
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment